An issue with deleting function

NoWeDoR · 07-23-2015, 03:32 AM

It can be deleted.

millgates · 07-23-2015, 06:43 AM

Ok, where do I start?

1/ Why are practically all your variables global? That's not a very good style.
2/ There's a lot of duplicate code in your program. That makes it more difficult to read, maintain and debug.
3/

Code:

static int counter = 0;

Why static?
4/ main does not return anything.
5/

Code:

struct personKnowledge *p;   // p = (Person)
p = (struct personKnowledge *)malloc(sizeof(struct personKnowledge));

Why the dynamic allocation?

6/

Code:

fwrite(&(*p), recordLength, 1, ptrFILE);

&(*p) is just p.

7/

Code:

number = -791673918435;

Err... what?

8/

Code:

	for (i = 1; i <= totalRecordNumber; i++)
	{
		if (i == number)
		{
			Sleep(350);
			printf("The record has been cleared.\n");
			continue;
		}
		else
		{
			fwrite(&(*del), recordLength, 1, ptrFILE1);
		}
	}

This just writes the first record of the original file n-1 times into the new file.

rtmistler · 07-23-2015, 02:48 PM

@NoWeDoR:

Hi,

Welcome to LQ.

Please review the Welcome to LQ thread for some help in asking your question better.

And sorry, but you've deleted your question at the time I've encountered it. This does not help future persons who may be seeking a solution to a similar problem. Therefore we cannot tell if the first answer was unhelpful or if your question was too unclear. Please consider leaving the question intact and making a new response if you feel that you wish to pull back the question and not have it considered to answering. Another thing to do is to close the thread using Thread Tools and mark it as solved, along with a comment saying "I've decided not to follow-up on this, please ignore my original question."

Regards,

- RT