[SOLVED] [clarification] File handling fopen, open

skaushal_lk · 03-25-2012, 11:58 PM

Hi Friends,

I need a clarification that if I do fopen() then open() and use fclose() not using close() before fclose() will it cause issue?

Code:

main(){
        int fd = -1, ret;
        FILE *fp=NULL;

        fp = fopen("sk.txt", "r");

        if(NULL == fp)
        {
                printf("can't open file\n");
                exit(1);
        }

         if ((fd = open( "sk.txt", O_RDWR | O_CREAT | O_SYNC | S_IRUSR )) < 0)
        {
                printf("can't open file twice fd=%d\n", fd);
                
        }
       
                printf(" open file twice fd=%d\n", fd);

        fclose(fp);
}

Do I need to have close() before fclose?

acid_kewpie · 03-27-2012, 09:29 AM

well you need firstly close files that are open. your code there tests if the file fopen'd but in the end fclose's it regardless. not neat.

And as for you original query, they are different file handles, so have nothing in common at all, so you should not be looking at them as a connected entity. your code doesn't close fd, end of story.

skaushal_lk · 03-27-2012, 11:17 PM

Thanx Chris for clarification.

Quote:

Originally Posted by acid_kewpie

And as for you original query, they are different file handles, so have nothing in common at all, so you should not be looking at them as a connected entity. your code doesn't close fd, end of story.

As per your comment I should have fclose() for fopen() and close() for open() since both file handles are different. Otherwise prg won't close the file neatly before exiting.