[SOLVED] [bash] while loop ..always print the first variable.

ridwanfi · 06-08-2011, 08:54 PM

Greetings,
it's look like i have a mistakes on my understanding of loop in bash shell. I write a simple script but, it always repeat the first variable and soon, in every text it made.

Code:

#!/bin/bash
username=/tmp/username.txt
emailadd=/tmp/emailadd.txt

        while read list; do
           while read name; do
            echo "Hello $read" >> /tmp/$list.txt
           done < $username
       echo " your email is $list" >> /tmp/$list.txt
       done < $emailadd

my goal is to create each .txt file with a name of a user, contains a name and an email address on his body text;

Hello user1
your email is email1

while i get with above code is, it creating each user email address.txt with every line of username printed.

Hello user1
Hello user2
your email is email1

I am really appreciate your help.

adamben · 06-08-2011, 09:15 PM

I think this article will essentially describe something close(ish) to what you are trying to do. Your output makes sense. For every single item in your first list, you are going to do the inner nested while loop.

http://www.linuxjournal.com/content/...multiple-files

grail · 06-08-2011, 09:31 PM

Also you are implying that both the files being read from are in the correct sorted order.

As for your while loops, you have said for each line in emailadd process the entire file username.

konsolebox · 06-09-2011, 09:04 AM

You might mean this one:

Code:

#!/bin/bash

username=/tmp/username.txt
emailadd=/tmp/emailadd.txt

while read -u 3 uname && read -u 4 email; do
	echo "Hello $uname your email is $email."
done 3< "$username" 4< "$emailadd" >> "/tmp/$list.txt"

Note: I changed $name to $uname. I have an uncertain memory of having a bug using that variable in my early experiences with bash. So just to make sure..

ridwanfi · 06-10-2011, 05:01 AM

thank's for your help konsolebox
it's work for me, i have try it.

Code:

#!/bin/bash

username=/tmp/username.txt
emailadd=/tmp/emailadd.txt

while read -u 3 uname && read -u 4 email; do
	echo "Hello $uname your email is $email."
done 3< "$username" 4< "$emailadd" >> "/tmp/$list.txt"

konsolebox · 06-10-2011, 08:12 AM

Quote:

Originally Posted by ridwanfi

thank's for your help konsolebox

wow it's been a while since i heard that.. i just feel thankful.
you're welcome

also, you can mark this thread as solved if you like..