Dear All,

I wrote a bash script which reads values and put in DB. I am facing issue with value of variable "Server_ip" while running this script via cron job.When I execute this script manually, it inserts all values in DB correctly. But when I try to run this script via cron job it misses Server_ip value inserting in DB.

Script is as follows:

##########################

#/!bin/bash


Server_ip=$(ifconfig eth0 | grep "inet addr" | awk -F: '{print $2}' | awk '{print $1}')

Current_Year=$(date +'%Y')

Today_Date=$(date | cut -b5-10)

Yesterday_Date=$(date --date="1 days ago" | cut -b5-10)


#last | grep "$Today_Date" > /home/kamran/ssh_logins.txt

last | grep "$Yesterday_Date" > /home/kamran/ssh_logins.txt

cat /home/kamran/ssh_logins.txt | grep . | grep -v reboot | grep -v shutdown |grep -v wtmp | grep -v tty | awk '{print $1","$2"," $3 "," $4 "-" $5 "-" $6 "," $7 "," $9}' > /home/kamran/output.csv

IFS=,
while read Login_Name Login_Terminal Login_IP Login_Date Login_Start_Time Login_End_Time
do
echo "INSERT INTO ssh_logins (Login_Name,Login_Terminal,Login_IP,Login_Date,Login_Start_Time,Login_End_Time,Server_ip,Current_Yea r) VALUES('$Login_Name','$Login_Terminal','$Login_IP','$Login_Date','$Login_Start_Time','$Login_End_Tim e','$Server_ip','$Current_Year');"
done < /home/kamran/output.csv | mysql -hlocalhost -uroot -ppassword ssh_logins;

#################


Cron entry looks like as follows:

00 01 * * * /home/kamran/ssh-logins1.sh > /dev/null 2>&1.

I dont know why it is missing to insert Server_ip variable while running with cron.
Please help.

Regards.
Kamran

Did you check
ifconfig eth0 | grep "inet addr" | awk -F: '{print $2}' | awk '{print $1}'
output? Not from script, just from terminal?
For me it shows nothing, empty string.
AFAIK your command will lead to empty Server_ip.
Its my output for "ifconfig eth0".
Note that there is no "inet addr" substring in ifconfig output, so grep will not pipe any substring to awk.
Maybe you have to change grep "inet addr" to grep "inet" and correct parameters for awk?

Dear Teufel,

Following is my output :

[root@test ~]# echo Server_ip=$(ifconfig eth0 | grep "inet addr" | awk -F: '{print $2}' | awk '{print $1}')
Server_ip=10.111.5.215

Output of ifconfig eth0 is :

[root@test ~]# ifconfig eth0
eth0 Link encap:Ethernet HWaddr 00:11:85:BB:FF:0A
inet addr:10.111.5.215 Bcast:10.111.5.255 Mask:255.255.255.0
inet6 addr: fe80::211:85ff:febb:ff0a/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:19839036 errors:0 dropped:0 overruns:0 frame:0
TX packets:141193 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:2173800523 (2.0 GiB) TX bytes:32200612 (30.7 MiB)
Interrupt:49

Thanks

regards,
Kamran

May be your server's output differs?
OK, you could temporary set you variable Server_ip like this:
Server_ip=$(ifconfig eth0)
It will fill your database field with full ifconfig output. And you could read it from database to get idea, what a real value will be passed to DB by ifconfig.

P.S.
DB field for Server_ip must be enough length to fit all ifconfig output

Dear Teufel,

Same effect. When I run script manually after replacing server_ip variable value it fills in DB column value.
But when same script tries with cron job it has not fill any value in column Server_ip.

Don't know what is effecting the script to run via cron job in this scenario.

Regards,
kamran

Can you redirect to text file (log) your INSERT statement to look how exactly INSERT query looks like?

Dear Teufel,

Following is the output for redirecting my insert query to text file.

[root@test ~]# cat /home/kamran/output.txt
INSERT INTO ssh_logins (Login_Name,Login_Terminal,Login_IP,Login_Date,Login_Start_Time,Login_End_Time,Server_ip,Current_Yea r) VALUES('kamran','pts/0','10.111.11.135','Fri-Nov-7','00:34','05:01','10.111.5.215','2014');

But main issue I am facing is running this script via cron job.When I run script manually it exactly dies what I want and what it is showing in above output. But when I run via cron job it misses server_ip field.

regards,
Kamran

It's strange enough
The only suspicious thing I see in your script is that your script should start with this line:
not
Sometimes blank strings (or strings like #########) may lead to unpredictable errors.
It's just shot in the dark, but nevertheless, change it to correct #!/bin/bash in very first line.

Dear Teufel,

My script starts with #!/bin/bash.

Those ######## signs I put here are just my marker line for reading script start here in thread.

Script does not originally contains these signs.
Thanks for your efforts.

Anybody else who can help in this regard please. I dont know what is doing wrong when executing script via cron job.

Regards,
Kamran

OK, I installed cron just out of curiosity, whats the matter and run this script:
Note that INSERT statement exactly the same as you posted above, I just copypasta it from your first message.
So, what I got on cron activation in testfile:
Note that ' e' field before Server_ip place.

After that I changed your INSERT statement like this:
and got this string in testfile:
It works for me even by running via cron.
Probably you have to check you script letter-by-letter once more to prevent random syntax errors, unnecessary white spaces, CRLFs e.t.c

And please wrap your code with tag. It helps to read code.

Dear Teufel,

That e is basically end letter of last field "Login_End_Time".
I have a workaround for this issue by hardcoding server ip in script just like

Server_ip=x.x.x.x.x

And in this way it got correct insert values even by runnning script via cron.

I will give more time to this to sort it out that why not working with cron when picking variable value from awk&ifconfig.
Thanks for giving your time.

Regards,
Kamran