bash scripting question

bmfan · 11-04-2005, 04:30 PM

Im making myself a litle script that i can use to join screenshots with, the screenshots might be jpg's or they could be png's . heres the script

Code:

#!/bin/bash
read -p "Enter Output Filename :" NM
read -p "Enable Shadow ? y/n :" S
read -p "Enter The Number of Tiles wide :" TW
if [[ "$S" = [yY]* ]]; then
  echo "--- Joining Images, Please Wait ---"
  montage *.jpg *.png  -shadow -geometry +4+4 -tile "$TW"x -quality 70 $NM  | tail
  echo "--- Joining Complete ---"
  else
  echo "--- Joining Images, Please Wait ---"
  montage *.jpf *.png  -geometry +1+1 -tile "$TW"x -quality 70 $NM  | tail
  echo "--- Joining Complete ---"
 fi

it works as is, however if its a directory full of png's it will say can't open *.jpg. im looing for a way for the script to join eith png's or jpg's. without spiting out that error. any ideas ?

acid_kewpie · 11-04-2005, 05:28 PM

you want to just sink that error? redirect stderr to /dev/null: "command -option parameter 2> /dev/null" is that all you're after?

bmfan · 11-04-2005, 05:30 PM

yeah i just want to get rid of the error the script works as is, it just spits out that error for either *.jpg or *.png depending on which is in the directory

ioerror · 11-04-2005, 05:54 PM

Just use *.{jpg,png} instead of specifying them seperately. If one or other doesn't exist, it
will be ignored.

bmfan · 11-04-2005, 05:58 PM

ive tried that
montage *.{jpg,png} -shadow -geometry +4+4 -tile 3x v.jpg
it still spits out the error
montage: unable to open image `*.png': No such file or directory.

ioerror · 11-04-2005, 06:08 PM

Oh, right. There should be a shell option to ignore failed matches. In zsh (which is what I use), it's 'setopt nomatch'. With bash, try 'set -o nomatch'. I haven't used bash for years though so I'm not sure about that. Have a look at the man page (search for, say, 'globbing') if 'nomatch' is not recognized.

homey · 11-04-2005, 08:54 PM

How about something like this

Code:

#!/bin/bash

read -p "Enter Output Filename :" NM
read -p "Enable Shadow ? y/n :" S
read -p "Enter The Number of Tiles wide :" TW
if [[ "$S" = [yY]* ]]; then
  echo "--- Joining Images, Please Wait ---"
  montage *.jpg *.png -shadow -geometry +4+4 -tile "$TW"x -quality 90 $NM  2> /dev/null | tail
  echo "--- Joining Complete ---"
else
  echo "--- Joining Images, Please Wait ---"
  montage *.jpg *.png -geometry +1+1 -tile "$TW"x -quality 90 $NM  2> /dev/null | tail
  echo "--- Joining Complete ---"
 fi