[SOLVED] Bash Script to register different host to Spacewalk

vwtech · 03-01-2014, 09:03 PM

Trying to make this script register host, two different spacewalk servers based on the distro and the last character of it's name.
The first if and elif condition work but after that it doesn't seem to honor the next if conditions. Anyone see what I'm doing wrong?

Code:

server=`/bin/hostname`
hostn=`/bin/hostname|awk -F. '{ print $1 }'| egrep -o .$`
type=`cat /etc/redhat-release|awk '{ print $NF }'`
centos=`cat /etc/redhat-release|awk '{ print $1 }'`

if [ $type = "(Tikanga)" ] && [ $hostn = "t" ] || [ $hostn = "d" ]
then
    rhnreg_ks --serverUrl=http://servername/XMLRPC --activationkey=1-OEL5 --force
elif [ $type = "(Tikanga)" ] && [ $hostn = "p" ]
then
    rhnreg_ks --serverUrl=http://servername/XMLRPC --activationkey=1-OEL5 --force
elif [ $type = "(Santiago)" ] && [ $hostn = "t" ] || [ $hostn = "d" ]
then
    rhnreg_ks --serverUrl=http://servername/XMLRPC --activationkey=1-OEL6 --force
elif [ $type = "(Santiago)" ] && [ $hostn = "p" ]
then
    rhnreg_ks --serverUrl=http://servername/XMLRPC --activationkey=1-OEL6 --force
elif [ $centos = "CentOS" ] && [ $hostn = "t" ] || [ $hostn = "d" ]
then
    rhnreg_ks --force --serverUrl=http://servername/XMLRPC --activationkey=1-CENT6
elif [ $centos = "CentOS" ] && [ $hostn = "p" ]
then
    rhnreg_ks --force --serverUrl=http://servername/XMLRPC --activationkey=1-CENT6
else
    echo "The host $server doesn't meet the requirements to register!"
fi

chrism01 · 03-02-2014, 12:52 AM

Have your tried adding 'set xv' at the top to see what its actually doing?
I also recommend double [[ ]] http://tldp.org/LDP/abs/html/testcon...ml#DBLBRACKETS

vwtech · 03-02-2014, 02:55 AM

Even with double quotes it doesn't honor, it will do the systems that hostname ends with "t" but not the "d".
Crazy part is if I make it the first if statement it will work but then another condition a few lines down won't.

Code:

[[ $type = "(Tikanga)" && $hostn = "t" || $hostn = "d" ]]

chrism01 · 03-03-2014, 05:59 AM

Like I said, try adding 'set -xv' at the top; it shows you what the parser is actually doing.

vwtech · 03-03-2014, 04:29 PM

Put "set -vx" at the top of my script and it does show what gets executed:

Code:

+ [[ (Santiago) = \(\T\i\k\a\n\g\a\) ]]
+ [[ d = \d ]]
+ rhnreg_ks --serverUrl=http://servername01t/XMLRPC --activationkey=1-OEL5 --force

But since the out put from the three conditions I'm using are (Santiago) and d ,it should have run

Code:

rhnreg_ks --serverUrl=http://servername/XMLRPC --activationkey=1-OEL6 --force

Per my condition.

byau · 03-03-2014, 07:37 PM

Looks like it just gets answered by the first right away. Which shell are you using? Or better yet can you hard code the shell in your script?

e.g.

#!/bin/bash

set -vx
server=`/bin/hostname`

etc..etc..

I ran a test version of your script through #!/bin/bash and #!/bin/sh and worked fine for me. So the only thing I can think of is your shell is not handling your "=" comparison the way you think it is.

In programming, sometimes for example for "=" you need to use "eq" or "==" because "=" is setting a variable, not comparing it.

So depending on what shell you're using, read man page for that shell and see what it expects as a comparison operator for "equals"

Thanks,

vwtech · 03-03-2014, 09:16 PM

I'm using the bash shell

The top of the script is has:

Code:

#!/bin/bash

set -vx
server=`/bin/hostname`

etc..etc..

It's a trip.

vwtech · 03-04-2014, 02:26 PM

Must have been with how the comparison works inside double brackets vs single brackets.
Even after figuring that part out it, didn't like to many if-statements with the double brackets (sounds crazy, I know).
The code below ended up working for me.

Code:

server=`/bin/hostname`
hostn=`/bin/hostname|awk -F. '{ print $1 }'| egrep -o .$`
type=`cat /etc/redhat-release|awk '{ print $NF }'`
centos=`cat /etc/redhat-release|awk '{ print $1 }'`
rhel5="(Tikanga)"
rhel6="(Santiago)"
test="t"
dev="d"

if [ $type == "$rhel5" ] && [ $hostn == "$test" ]
then
    rhnreg_ks --serverUrl=http://servername01t/XMLRPC --activationkey=1-OEL5 --force
elif [ $type == "$rhel5" ] && [ $hostn == "$dev" ]
then
    rhnreg_ks --serverUrl=http://servername01t/XMLRPC --activationkey=1-OEL5 --force
elif [[ $type = $rhel6 && $hostn = "t" || $hostn = "d" ]]
then
    rhnreg_ks --serverUrl=http://servername01t/XMLRPC --activationkey=1-OEL6 --force
elif [[ $centos = "CentOS" && $hostn = "t" || $hostn = "d" ]]
then
    rhnreg_ks --force --serverUrl=http://servername01t/XMLRPC --activationkey=1-CENT6
elif [[ $type = "(Tikanga)" && $hostn = "p" ]]
then
    rhnreg_ks --serverUrl=http://servername01p/XMLRPC --activationkey=1-OEL5 --force
elif [[ $type = "(Santiago)" && $hostn = "p" ]]
then
    rhnreg_ks --serverUrl=http://servername01p/XMLRPC --activationkey=1-OEL6 --force
elif [[ $centos = "CentOS" && $hostn = "p" ]]
then
    rhnreg_ks --force --serverUrl=http://servername01p/XMLRPC --activationkey=1-CENT6
else
    echo "The host $server doesn't meet the requirements to register!"