Hi there.

I don't have much experience or any training with shell scripts so please forgive any stupid questions or mistakes.

I have a folder that contains different files. I need a script that will find only files that have the word "CYCLIC" in the filename and for those files only, find and replace any text within the file that matches "CTRRET" with "CYCLIC_CTRRET".

Here is what I have come up with after taking bits and pieces from various forum discussions, but it doesn't work. I'm hoping someone could show me where I'm going wrong.

*******************************************

#!/bin/bash

basePath="/cygdrive/$DOC1_DRIVE/conret/"

for f in $basePath
do
if [ $fn = *CYCLIC* ]
then
sed -i "s/_CTRRET/_CYCLIC_CTRRET/g" "$f"
fi
done

*******************************************

I'd appreciate any help anyone could provide.

Thank you.

Basically in your script the offending line is
where fn is not the loop variable and the comparison does not make sense. Not to mention the loop cycles only once over the value of the basePath variable. My suggestion is to keep it simple and use a one-line stream of commands, e.g.
Feel free to ask if something is not clear about this command.

1 members found this post helpful.

why don't you execute
it will send an error message if there was no such file, otherwise it works




_______________________
Happy with solution ... mark as SOLVED
If someone helps you, or you approve of what's posted, click the "Add to Reputation" button, on the left of the post.

This would work if the files were all in the same directory, but it's not recursive. Anyway, you make me notice that the word CYCLIC must be in the filename, not inside the file. Therefore instead of grep we can use find to search recursively inside the base directory:
@Simon1984: please notice the echo command after -exec: it is for testing purposes. It will display the sed commands without actually execute them, so that you can check the result to see if it works as expected.

That's why:

Also based on the original "script" there are no subdirs in this case. But I'm not really sure

Let's see. The OP should clarify (hopefully).

thanks for the suggestions guys

All my files are in the same folder so I tried the following code and it works fine

sed -i 's/_CTRRET/_CYCLIC_CTRRET/g' $basePath/*CYCLIC*


I appreciate all the suggestions and feedback as it's helped me to understand a bit more about how the code works.

Thanks again!