send output of command to different email address

aristosv · 11-13-2019, 09:46 AM

I am writing a loop that for each directory name it finds, will run some gcalcli commands and output calendar events. I also have a few if statements in the loop, and depending again on the directory name, it will create a variable for an email address. And then I want to send the output of the command to the correct email address.

The purpose is for each $client to receive the output of the gcalcli command on their $email.

I think I’m close, but it’s a bit confusing on how to place everything in the script.

Code:

#!/bin/bash

# variables
dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

for client in $(/usr/bin/ls -d */ | /usr/bin/sed 's#/##')
do

 if [[ $client = client1_name_here ]] ; then email=client1email@ishere ; fi
 if [[ $client = client2_name_is_here ]] ; then email=client2emailaddress@ishere ; fi
 if [[ $client = client3_name_is_placed_here ]] ; then client3email@isrighthere ; fi

 echo
 echo reminders for $client on $(date +%d-%m-%y)
 echo -------------------------------------------------------
 /usr/bin/gcalcli --config-folder $dir/$client/calendar agenda --tsv \
 "$(/bin/date -d 'now')" "$(/bin/date -d 'now + 24 hours')"

 echo $email
 /usr/bin/mail -s "reminders for $(date +%d-%m-%y)" $email

done

rnturn · 11-13-2019, 10:12 AM

Quote:

Originally Posted by aristosv

I am writing a loop that for each directory name it finds, will run some gcalcli commands and output calendar events. I also have a few if statements in the loop, and depending again on the directory name, it will create a variable for an email address. And then I want to send the output of the command to the correct email address.

The purpose is for each $client to receive the output of the gcalcli command on their $email.

I think I’m close, but it’s a bit confusing on how to place everything in the script.

Code:

#!/bin/bash

# variables
dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

for client in $(/usr/bin/ls -d */ | /usr/bin/sed 's#/##')
do

 if [[ $client = client1_name_here ]] ; then email=client1email@ishere ; fi
 if [[ $client = client2_name_is_here ]] ; then email=client2emailaddress@ishere ; fi
 if [[ $client = client3_name_is_placed_here ]] ; then client3email@isrighthere ; fi

 echo
 echo reminders for $client on $(date +%d-%m-%y)
 echo -------------------------------------------------------
 /usr/bin/gcalcli --config-folder $dir/$client/calendar agenda --tsv \
 "$(/bin/date -d 'now')" "$(/bin/date -d 'now + 24 hours')"

 echo $email
 /usr/bin/mail -s "reminders for $(date +%d-%m-%y)" $email

done

There appears to be a bug in that third "if" statement: Aren't you missing the "email=" ??

The "mail" command will appear to hang while it's waiting for input. If all you want to do is send the "Subject", you'll want to redirect /dev/null into the command:

Code:

/usr/bin/mail -s "reminders for $(date +%d-%m-%y)" $email < /dev/null

A better, friendlier solution might be to use something like:

Code:

echo "There is new stuff on your calendar." | /usr/bin/mail -s "reminders for $(date +%d-%m-%y)" $email

If you need to include calendar items in the body of the email, you'll need to redirect those into a temporary file, redirect that file into the mail command (rather like the "/dev/null" example above), and remove the temporary file.

HTH...

aristosv · 11-13-2019, 10:17 AM

The "email=" thing was a typo, thanks for pointing it out.

The "There is new stuff on your calendar." has to be the output of this:

Code:

 echo
 echo reminders for $client on $(date +%d-%m-%y)
 echo -------------------------------------------------------
 /usr/bin/gcalcli --config-folder $dir/$client/calendar agenda --tsv \
 "$(/bin/date -d 'now')" "$(/bin/date -d 'now + 24 hours')"

And it has to be sent to the $email variable, based on the if statements.

berndbausch · 11-13-2019, 06:32 PM

For more clarity, I'd use a case statement rather than if to map email addresses to user names.

What is this line supposed to do?

Code:

dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

Obviously initializing dir with the name of a directory, but why so complicated with all the double quotes flying around?

Also, if the part before the && generates an error, dir will be empty. Rather than redirecting all messages to /dev/null, you should handle that case. Or leave out the redirection.

Right now, the output of gcalcli and the reminder string go to stdout. You should pipe this into the mail command, either using a temporary file:

Code:

echo Reminder ..... > $TEMPFILE
gclacli .... >> $TEMPFILE
mail -s Reminder $email <$TEMPFILE

or grouping the echo and gcalcli commands and using a pipe:

Code:

{
echo Reminder ..... 
gclacli .... 
} | mail -s Reminder $email

NOTE: Not tested.

rnturn · 11-14-2019, 02:20 PM

Quote:

Originally Posted by aristosv

The "There is new stuff on your calendar." has to be the output of this:

The above would be the subject of the email.

Quote:

Code:

 echo
 echo reminders for $client on $(date +%d-%m-%y)
 echo -------------------------------------------------------
 /usr/bin/gcalcli --config-folder $dir/$client/calendar agenda --tsv \
 "$(/bin/date -d 'now')" "$(/bin/date -d 'now + 24 hours')"

The output of the above would be the body of the email. This is what should be redirected into a temp file and subsequently redirected into the mail command. I.e.,

Code:

mailx -s "There is new stuff on your calendar" joesmith@buy-n-large.com < client_event_list.tmp
rm client_event_list.tmp

...

# Loop to the next addressee...

To simplify things, I'd rewrite that bit of code as a shell function:

Code:

function get_events() {
   client=$1
   echo
   echo reminders for $client on $(date +%d-%m-%y)
   echo -------------------------------------------------------
   /usr/bin/gcalcli --config-folder $dir/$client/calendar agenda --tsv \
 "$(/bin/date -d 'now')" "$(/bin/date -d 'now + 24 hours')"
}

Then your processing loop would be something like:

Code:

declare -a CLIENTLIST                           # usually optional
CLIENTLIST=( $( code-to-generate-user-list ) )  # make array of users

for CLIENT in ${CLIENTLIST[@]}                  # loop on the client name array
do
   EMAILADDR=$( whatever code you used to obtain email address )
   TMPFILE=${CLIENT}.$RANDOM.$RANDOM.tmp        # temp file for event info

   get_events $CLIENT > $TMPFILE                # get list of events

   mailx -s "There is new stuff on your calendar" $EMAILADDR < $TMPFILE
   rm $TMPFILE                                  # cleanup the temp file

done

(I referenced "mailx" as that's what I tend to use for emailing from scripts. Adjust to your needs.)

HTH...

rnturn · 11-14-2019, 02:24 PM

Quote:

Originally Posted by berndbausch

Code:

dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

Obviously initializing dir with the name of a directory, but why so complicated with all the double quotes flying around?

Spaces in directory names? Spaces in file and directory names tend to make everything much more complicated. (Replace 'em with underscores and add years to your life.)

chrism01 · 11-14-2019, 09:31 PM

Quote:

Spaces in directory names? Spaces in file and directory names tend to make everything much more complicated. (Replace 'em with underscores and add years to your life.)

This +++++ - take it from one who has been there too many times ...