Remove(not) files based on property value

sukhdip · 08-29-2017, 06:24 AM

Hi All,

Need your help to fix one script.

Main agenda is:
1. Read a property file.
2. Delete all files in directory except the name from Property file.

I am trying to read property file for value then deleting all files from directory except THAT value/name.

I have tried so far as below:
Property File i.e., earBuild.properties

Code:

#EAR Names
earName=XYZ.ear

OR
Property file can be with Multiple Ear names as:

Code:

#EAR Names
earName=XYZ.ear
earName=ABC.ear

I have written below shell script but loop is deleting all files in directory.

Code:

#!/bin/bash

echo "Reading property file at `pwd`"
ls -lrt

find /tmp/s/earProps/ -name earBuild.properties

FILE_NAME="earBuild.properties"
echo "EAR property file is: $FILE_NAME"

EARPATH="/tmp/s/props/ears/"

# Key in Property File
KEY="earName"

# Variable to hold the Property Value
prop_value=""

getProperty()
{
        prop_key=$1
        prop_value=`cat ${FILE_NAME} | grep ${prop_key} | cut -d'=' -f2`
}

getProperty ${KEY}
echo "KEY = ${KEY} ; Value = " ${prop_value}

for i in ${prop_value}; do
	find $EARPATH -type f ! -name $i -exec rm -rf {} \;
	echo "Value of I in loop is $i"
done

I am no bound to use find or rm or even for loop. Looking for the solution.
Appreciate help in advance.

Thanks

michaelk · 08-29-2017, 10:08 AM

Each excluded file must be in the the same command. You can just print the results to test your program.

Code:

find . -maxdepth 1 ! -name  file_1 ! -name file_2  -type f  -print

MadeInGermany · 08-30-2017, 04:41 AM

grep searches in the entire line, and can find a key within a value.
Improvement

Code:

getProperty()
{
        prop_key=$1
        prop_value=`awk -F= '$1==key {print $2}' key="$prop_key" "$FILE_NAME"`
}

rm -r is recursive, should not be used in the recursive find.

Code:

for i in ${prop_value}; do
	find "$EARPATH" -type f ! -name "$i" -exec rm -f {} \;
	echo "Value of I in loop is $i"
done

A good diagnostic is to put echo before the rm then you see what it would do!

MadeInGermany · 08-30-2017, 05:58 AM

A function should be universal.
Using global variables is bad style.
I would return values on stdout like this

Code:

getProperty()
{
    awk -F= '$1==key {print $2}' key="$1" "$FILE_NAME"
}

And in the main code store it in a variable

Code:

prop_value=$(getProperty "$KEY")

Or pipe it to a while loop

Code:

getProperty "$KEY" |
while read i; do
	find "$EARPATH" -type f ! -name "$i" -exec rm -f {} \;
	echo "Value of I in loop is $i"
done

In this case it can all boil down to

Code:

while IFS="=" read k i; do
    if [ "$k" = "$KEY" ]; then
	find "$EARPATH" -type f ! -name "$i" -exec rm -f {} \;
	echo "Value of I in loop is $i"
    fi
done < "$FILE_NAME"

but maybe this is harder to understand/debug.