Help regarding a Perl script

user_28 · 08-17-2010, 10:59 AM

Hi,
Sorry for that. Earlier I modified my code according to the hint like this.

#!/usr/local/bin/perl

use File::Find ;

$search = shift || 'C:\Documents and Settings\user\Desktop' ;

# Get an array of all subdirectories
find sub { push @dirs, $File::Find::name if -d }, $search ;

for $dir ( @dirs ) {
opendir $dh, $dir or do { warn "Cannot open '$dir' $!" ; next ; } ;

opendir( DIR, "$dir" ) ;
@files = grep( /\./, readdir( DIR ) ) ;
closedir( DIR ) ;

foreach $file ( @files ) {

my $filesize = -s'$dir/$file';
print "$filesize\n"

}

}

user_28 · 08-17-2010, 11:09 AM

Hi,
Sorry. Below is the script which I made changes according to the hint
#!/usr/local/bin/perl

use File::Find ;

# Get the directory from the command line
# or use the default directory
$search = shift || 'p:\Documents and Settings\user\Desktop\' ;

find sub { push @dirs, $File::Find::name if -d }, $search ;

for $dir ( @dirs ) {
opendir $dh, $dir or do { warn "Cannot open '$dir' $!" ; next ; } ;

opendir( DIR, "$dir" ) ;
@files = grep( /\./, readdir( DIR ) ) ;
closedir( DIR ) ;

foreach $file ( @files ) {
my $filesize = -s'$dir/$file\n";
print -s '$filesize\n' ;

}

}

Thanks

druuna · 08-17-2010, 11:11 AM

Hi,

Compare your code with the working version I posted in post #15.

All your wishes (up till now) are implemented:
- Traverses a directory structure (base can be set on the command line, otherwise a default is set),
- Looks for files with 0 length and print message,
- Excludes 2 files, which are always zero length (foor and bar in example given).

user_28 · 08-17-2010, 11:22 AM

Hi,
Thank you so much. You have so helpful for my questions. From your scripts I learned a lot.

user_28 · 08-17-2010, 01:22 PM

Hi,
After I made changes according to the script given by druuna. I further added some code to the script like creating a log file and to discard hidden folders like .,... But the problem is it is listing out folders as zero size. I double checked and my folders do have some files in them . Not sure what went wrong. please help.

#!/usr/local/bin/perl
use File::Find ;

$search = shift || 'p:\Documents and Settings\user\Desktop\' ;

find sub { push @dirs, $File::Find::name if -d }, $search ;

for $dir ( @dirs ) {
opendir $dh, $dir or do { warn "Cannot open '$dir' $!" ; next ; } ;

opendir( DIR, "$dir" ) ;
@files = grep( !/^\.\.?$/, readdir( DIR ) ) ;

closedir( DIR ) ;

foreach $file ( @files ) {
my $filesize = -s "$dir/$file" ;
if ( $file ne "foo" && $file ne "bar" ) {
print "Warning: $dir/$file has size $filesize\n"
if ( $filesize == "0" ) ;

}
}
closedir( $dh ) ;

open LOG,">>log.txt";
print LOG "Warning: $file has size ZERO\n";

close LOG;
}

druuna · 08-17-2010, 02:14 PM

Have a look at this.

Code:

#!/usr/bin/perl

use File::Find ;

$search = shift || '/data/Downloads' ;
$outfile = 'log.txt' ;

open OUTF, ">$outfile" or die print "Can't create logfile: $!" ;

find sub { push @dirs, $File::Find::name if -d }, $search ;

for $dir ( @dirs ) {
   opendir $dh, $dir or do { warn "Cannot open '$dir' $!" ; next ; } ;

   opendir( DIR, "$dir" ) ;
   @files = readdir( DIR ) ;
   closedir( DIR ) ;

   foreach $file ( @files ) {
      if ( -f "$dir/$file" ) {
         $filesize = -s "$dir/$file" ;
         if ( $file ne "foo" && $file ne "bar" ) {
            print OUTF "Warning: $dir/$file has size ZERO\n"
              if ( $filesize == "0" ) ;
         }
      }
   }
   closedir( $dh ) ;
}

close OUTF ;

exit 0 ;

BTW: I'm not seeing the 3 files in the code you posted that are always zero (mentioned in posts #1, #3 and #12).

user_28 · 08-17-2010, 02:35 PM

Hi,
Thank you. It is working now and regarding the file names that are always zero. I am not still working on real data so I created two empty files and gave their names in place of foor and bar and the script is working fine now. Really thanks a lot!

druuna · 08-18-2010, 03:13 AM

@caseycolin: ????

What is the link about: Spam!

Reported! Edit: Moderator cleaned spam message.