Error on the #!/bin/bash line?

L_Carver · 11-13-2018, 11:12 AM

Code:

#!/bin/bash

set -xv

function mongol() {
echo -e "What list will I be using?"
read -er smash
}
mongol
echo "$smash"
while IFS=":" read -er fg rg
do
echo "$fg"
pg=$(perl -e "print $fg*12.75")
echo "$rg"


exiv2 --keep -M"set Xmp.xmp.Rating $rg" -M"set Xmp.xmp.RatingPercent $pg" "$fg"  2>/dev/null
echo "$fg now has a MS Photo Rating of $rg."
done< "$smash"
files=(*temp)
	echo "$files">>killtemp.log
    rm "$files" 2>/dev/null
   	echo "Done."

That's what I get when I run it.

Shellcheck errors include (installed, online checks out fine):

Code:

line 22:
        echo "$files">>killtemp.log
              ^-- SC2128: Expanding an array without an index only gives the first element.

I'm at a loss.
(And you will note that the script, as pasted here, starts with a "set -xv.)

Carver

scasey · 11-13-2018, 11:17 AM

Quote:

That's what I get when I run it.

What's what you get when you run it?

Do you not understand the warning?

l0f4r0 · 11-13-2018, 11:21 AM

Quote:

Originally Posted by L_Carver

Shellcheck errors include (installed, online checks out fine):

Code:

line 22:
        echo "$files">>killtemp.log
              ^-- SC2128: Expanding an array without an index only gives the first element.

I'm at a loss.

For me it's just a warning for you to be reviewed if need be...

teckk · 11-13-2018, 02:47 PM

Quote:

For me it's just a warning for you to be reviewed if need be...

It's a warning for you to correct.

Code:

array=(
one
two
three
four
)

echo "$array"
one

echo "${array[@]}"
one two three four

l0f4r0 · 11-14-2018, 06:55 AM

Quote:

Originally Posted by teckk

It's a warning for you to correct.

Technically speaking, echo "$array", is totally ok.
If it is to be corrected eventually, that's just because it's not what the OP expected initally when he coded it (and I agree with you it's probably not the case indeed -> echo "${array[@]}").

pan64 · 11-14-2018, 07:50 AM

Yes, do you understand the message?
How is your post related to the title (Error on the #!/bin/bash line?)

MadeInGermany · 11-14-2018, 12:41 PM

You can store in an array

Code:

files=(*temp)
echo "in one row:"
echo "${files[@]}"
echo "on separate rows:"
printf "%s\n" "${files[@]}"

Or you can store in a simple variable, best in rows:

Code:

files=$(printf "%s\n" *temp)
echo "$files"

Or you use a loop; treating each file individually enables you to test them

Code:

for file in *temp
do
  [ -f "$file" ] || continue
  echo "$file"
done

If you want to append to a logfile, then

Code:

done >> logfile

(one open/close) is more efficient than

Code:

  echo "$file" >> logfile

(open/close) for each loop cycle.