[SOLVED] code is giving error

santosh0782 · 06-04-2014, 02:23 AM

Hi,

i have a data file as:

cat INPUT_DATA
03-06-2014|01:45:00|Successful Transactions|1002
03-06-2014|01:45:00|Successful Transactions Amount|273.54
03-06-2014|01:45:00|FAS Failure Transactions|98723
03-06-2014|01:45:00|FAS Failure Transactions Amount|86.82
03-06-2014|01:45:00|Falcon Failure Transactions|14
03-06-2014|01:45:00|Falcon Failure Transactions Amount|51.350

Code:

file="INPUT_DATA"

while IFS=\| read DATE TIME LABEL VALUE  # IFS = Internal File Seperator
do
        if [[ $LABEL == "Successful Transactions" ]]
        then
        succ_trnx=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ $LABEL == "Successful Transactions Amount" ]]
        then
        succ_trnx_amt=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ $LABEL == "FAS Failure Transactions" ]]
        then
        fas_fail_trnx=$(echo "${VALUE}" |sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ $LABEL == "FAS Failure Transactions Amount" ]]
        then
        fas_fail_trnx_amt=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ $LABEL == "Falcon Failure Transactions" ]]
        then
        flcon_fail_trnx=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ $LABEL == "Falcon Failure Transactions Amount" ]]
        then
        flcon_fail_trnx_amt=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi
     

        hour=$(echo ${TIME} | cut -c1-5)
        date1=$DATE
       
        TOT_TRNXS=$(echo "$succ_trnx + $fas_fail_trnx + $flcon_fail_trnx"| bc)
        TOT_FAS_DCLD_TRNXS=${fas_fail_trnx}
        TOT_FLCN_DCLD_TRNXS=${flcon_fail_trnx}
        TOT_TRNX_AMT=$(echo "scale=2; succ_trnx_amt+fas_fail_trnx_amt+flcon_fail_trnx_amt"|bc)
        TOT_DCLD_TRNXS_AMT=$(echo "scale=2; ${fas_fail_trnx_amt}+${flcon_fail_trnx_amt}"|bc)

        echo "TOT_TRNXS=$TOT_TRNXS"
        echo "TOT_FAS_DCLD_TRNXS=$TOT_FAS_DCLD_TRNXS"
        echo "TOT_FLCN_DCLD_TRNXS=$TOT_FLCN_DCLD_TRNXS"
        echo "TOT_TRNX_AMT=$TOT_TRNX_AMT"
        echo "TOT_DCLD_TRNXS_AMT=$TOT_DCLD_TRNXS_AMT"


done <"$file"

error:
(standard_in) 1: parse error
(standard_in) 1: parse error
TOT_TRNXS=
TOT_FAS_DCLD_TRNXS=
TOT_FLCN_DCLD_TRNXS=
TOT_TRNX_AMT=0
TOT_DCLD_TRNXS_AMT=
(standard_in) 1: parse error
(standard_in) 1: parse error
TOT_TRNXS=
TOT_FAS_DCLD_TRNXS=
TOT_FLCN_DCLD_TRNXS=
TOT_TRNX_AMT=0
TOT_DCLD_TRNXS_AMT=
(standard_in) 2: parse error
(standard_in) 1: parse error
TOT_TRNXS=
TOT_FAS_DCLD_TRNXS=98723
TOT_FLCN_DCLD_TRNXS=
TOT_TRNX_AMT=0
TOT_DCLD_TRNXS_AMT=
(standard_in) 2: parse error
(standard_in) 2: parse error
TOT_TRNXS=
TOT_FAS_DCLD_TRNXS=98723
TOT_FLCN_DCLD_TRNXS=
TOT_TRNX_AMT=0
TOT_DCLD_TRNXS_AMT=
(standard_in) 2: parse error
TOT_TRNXS=99739
TOT_FAS_DCLD_TRNXS=98723
TOT_FLCN_DCLD_TRNXS=14
TOT_TRNX_AMT=0
TOT_DCLD_TRNXS_AMT=
TOT_TRNXS=99739
TOT_FAS_DCLD_TRNXS=98723
TOT_FLCN_DCLD_TRNXS=14
TOT_TRNX_AMT=0
TOT_DCLD_TRNXS_AMT=138.170

could someone please help to sort out this error?

pan64 · 06-04-2014, 02:38 AM

yes, insert set -xv at the beginning of the script and you will see what's happening.
put your variable inside ", so use "$LABEL", also check other variables. in line TOT_TRNX_AMT= even the $ signs are missing....

santosh0782 · 06-04-2014, 03:55 AM

Quote:

Originally Posted by pan64

yes, insert set -xv at the beginning of the script and you will see what's happening.
put your variable inside ", so use "$LABEL", also check other variables. in line TOT_TRNX_AMT= even the $ signs are missing....

i have added the " to "$LABEL" and $ sign to the missings one, also run the script in debugging mode:

Code:

#!/bin/ksh
set -xv

file="INPUT_DATA"

while IFS=\| read DATE TIME LABEL VALUE  # IFS = Internal File Seperator
do
        if [[ "$LABEL" == "Successful Transactions" ]]
        then
        succ_trnx=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ "$LABEL" == "Successful Transactions Amount" ]]
        then
        succ_trnx_amt=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ "$LABEL" == "FAS Failure Transactions" ]]
        then
        fas_fail_trnx=$(echo "${VALUE}" |sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ "$LABEL" == "FAS Failure Transactions Amount" ]]
        then
        fas_fail_trnx_amt=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ "$LABEL" == "Falcon Failure Transactions" ]]
        then
        flcon_fail_trnx=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi

        if [[ "$LABEL" == "Falcon Failure Transactions Amount" ]]
        then
        flcon_fail_trnx_amt=$(echo "${VALUE}" | sed -e 's/^ *//g;s/ *$//g')
        fi


        hour=$(echo ${TIME} | cut -c1-5)
        date1=$DATE

        TOT_TRNXS=$(echo "$succ_trnx + $fas_fail_trnx + $flcon_fail_trnx"| bc)
        TOT_FAS_DCLD_TRNXS=${fas_fail_trnx}
        TOT_FLCN_DCLD_TRNXS=${flcon_fail_trnx}
        TOT_TRNX_AMT=$(echo "scale=2; $succ_trnx_amt + $fas_fail_trnx_amt + $flcon_fail_trnx_amt"|bc)
        TOT_DCLD_TRNXS_AMT=$(echo "scale=2; ${fas_fail_trnx_amt}+${flcon_fail_trnx_amt}"|bc)


        echo "TOT_TRNXS=$TOT_TRNXS"
        echo "TOT_FAS_DCLD_TRNXS=$TOT_FAS_DCLD_TRNXS"
        echo "TOT_FLCN_DCLD_TRNXS=$TOT_FLCN_DCLD_TRNXS"
        echo "TOT_TRNX_AMT=$TOT_TRNX_AMT"
        echo "TOT_DCLD_TRNXS_AMT=$TOT_DCLD_TRNXS_AMT"
done <"$file"

part of output:
+ 0< INPUT_DATA
+ read DATE TIME LABEL VALUE
+ IFS='|'
+ [[ 'Successful Transactions' == 'Successful Transactions' ]]
+ echo 1002
+ sed -e 's/^ *//g;s/ *$//g'
+ succ_trnx=1002
+ [[ 'Successful Transactions' == 'Successful Transactions Amount' ]]
+ [[ 'Successful Transactions' == 'FAS Failure Transactions' ]]
+ [[ 'Successful Transactions' == 'FAS Failure Transactions Amount' ]]
+ [[ 'Successful Transactions' == 'Falcon Failure Transactions' ]]
+ [[ 'Successful Transactions' == 'Falcon Failure Transactions Amount' ]]
+ echo 01:45:00
+ cut -c1-5
+ hour=01:45
+ date1=03-06-2014
+ echo '1002 + + '
+ bc
(standard_in) 1: parse error
+ TOT_TRNXS=''
+ TOT_FAS_DCLD_TRNXS=''
+ TOT_FLCN_DCLD_TRNXS=''
+ echo scale='2; + + '
+ bc
(standard_in) 1: parse error
+ TOT_TRNX_AMT=''
+ echo scale='2; +'
+ bc
(standard_in) 1: parse error
+ TOT_DCLD_TRNXS_AMT=''
+ echo TOT_TRNXS=
TOT_TRNXS=
+ echo TOT_FAS_DCLD_TRNXS=
TOT_FAS_DCLD_TRNXS=

not able to understand, why the error is?

pan64 · 06-04-2014, 04:01 AM

for example here:

Quote:

+ echo '1002 + + '

you can see there are no real values just + signs. It happened because you tried to print the report inside the while loop and the input lines has not been (yet) evaluated.

santosh0782 · 06-04-2014, 07:25 AM

Quote:

Originally Posted by pan64

for example here: you can see there are no real values just + signs. It happened because you tried to print the report inside the while loop and the input lines has not been (yet) evaluated.

Thanks a lot :-) i did the calculations outside the while loop and it worked. Thanks :-)

grail · 06-04-2014, 08:43 AM

You could also look into all the duplication you have to minimise the code and make it a little clearer.

And is there really white space around the last value at all? Just the sed seems a bit of an overkill, especially the use of 'g' seeing you are removing space from the start and the end, these
positions only appear once so the 'g' is a little superfluous.

santosh0782 · 06-11-2014, 11:49 PM

Quote:

Originally Posted by grail

You could also look into all the duplication you have to minimise the code and make it a little clearer.

And is there really white space around the last value at all? Just the sed seems a bit of an overkill, especially the use of 'g' seeing you are removing space from the start and the end, these
positions only appear once so the 'g' is a little superfluous.

oh yes, i'll remove the 'g' from sed. Thanks a lot :-)