[SOLVED] bash script modification help relating to linking html files for download

Davno · 09-06-2018, 02:57 PM

Hi.
I have a bash script that create a .html file that list all the files from a specific folder showing the date, the quantity of files in that folder, their titles, order numbers, ect...
Then that script copies that .html file to my Apache server.
I want to modify that script or may be the resulting .html file in order to link those files for download.
I know how to link a line to a file (one by one is not an option) or i could make the directory content downloadable but i rather modify the script instead, is it possible and how should i do it? Thank You.

Here is a sample of that script:

Code:

#!/bin/bash
# y
cd /media/norm/83644822B578E/x/y/
date > ty.html
echo "<hr>" >> ty.html
echo "y<br />" >> ty.html
number=`ls *.txt | wc -l`
echo "Their is $number y in this folder.<br />" >> ty.html
echo "<hr>" >> ty.html
count=0
for i in *txt ; do
#echo item: $i
((count+=1))
echo "# $count<br />" >> ty.html
echo $i "<br>" >> ty.html
done

cp /media/norm/83644822B578E/x/y/ty.html /var/www/html/list

scasey · 09-06-2018, 03:03 PM

Isn't it just changing

Code:

echo $i "<br>" >> ty.html

to

Code:

echo "<a href=$i>$i</a> <br>" >> ty.html

Or am I missing something?

Davno · 09-06-2018, 03:09 PM

Ill try that, Thxs

scasey · 09-06-2018, 03:19 PM

Sorry...the href needs to be quoted...try

Code:

echo '<a href="$i">$i</a> <br>' >> ty.html

BW-userx · 09-06-2018, 03:23 PM

have you thought about maybe tar'ing all of the files then attach that to your download link to save time having to click each and every link to get the entire contents?

your loop in the script should be controlled by your total count or EOF. or a while loop even.

Code:

#!/bin/bash

script_dir=/holding_dir_for_file
search_dir=/where_ever
count=0

#header code and date time stamp echo'ed in here, 
#then add links here

while read f ; do
{
    echo "<a href="\"$f\"">$f</a>" >> ty.html
    ((count++))
}
done <<<"$(find "$search_dir" -type f )"

echo " total files : $count " >> ty.html

#then finalizing code to end your html file suitable for hosting here

cp or mv $script_dir/ty.html /var/www/html/list

then just run the script from a cental location

Davno · 09-06-2018, 03:29 PM

ty.html is being created with the folder content listed in it, and all lines show a link in "blue" but all the line point to where the new ty.html is located (in var/www/html/list) not where the the .txt files are located
(/media/norm/83644822B578E/x/y)

scasey · 09-06-2018, 03:50 PM

Quote:

Originally Posted by Davno

ty.html is being created with the folder content listed in it, and all lines show a link in "blue" but all the line point to where the new ty.html is located (in var/www/html/list) not where the the .txt files are located
(/media/norm/83644822B578E/x/y)

You need to construct the href value to be correct...pre-pend the path to the contents of the href= string:

Code:

echo '<a href="/media/norm/83644822B578E/x/y/$i">$i</a> <br>' >> ty.html

If that's where the files are located.

NOTE: Linking to the files will still require a visitor to right-click and select the appropriate item to download the file (On Firefox it's "Save link as...")
I'll need to remember how to make the link be a "download link"...I know I've done that...
Ahh (DDG is my friend)

Code:

echo '<a href="/media/norm/83644822B578E/x/y/$i" download="$i">$i</a> <br>' >> ty.html

Davno · 09-06-2018, 03:56 PM

Quote:

Originally Posted by scasey

Sorry...the href needs to be quoted...try

Code:

echo '<a href="$i">$i</a> <br>' >> ty.html

As per your first reply it listed the name of the .txt properly but they link where the ty.html is located.
And as per your second reply all the .txt are called "$1" in the ty.html and still link to the ty.html location.

Davno · 09-06-2018, 03:59 PM

Quote:

Originally Posted by scasey

You need to construct the href value to be correct...pre-pend the path to the contents of the href= string:

Code:

echo '<a href="/media/norm/83644822B578E/x/y/$i">$i</a> <br>' >> ty.html

If that's where the files are located.

NOTE: Linking to the files will still require a visitor to right-click and select the appropriate item to download the file (On Firefox it's "Save link as...")
I'll need to remember how to make the link be a "download link"...I know I've done that...

Thank YOu. I will try that.

scasey · 09-06-2018, 04:08 PM

Quote:

And as per your second reply all the .txt are called "$1" in the ty.html ...

Yes. You'll need to do it the way BW-userx posted...

Code:

"<a href=\"...\" download=\"$i\">$i</a>"

...that is, escape the internal quotes.

See w3shools

Davno · 09-06-2018, 04:13 PM

It work now.
Thank you very much.

michaelk · 09-06-2018, 04:17 PM

Just for a FYI you can create dynamic web pages using something like php or even convert your existing script to a CGI for a more automatic process.

Davno · 09-06-2018, 06:54 PM

Quote:

Originally Posted by scasey

You need to construct the href value to be correct...pre-pend the path to the contents of the href= string:

Code:

echo '<a href="/media/norm/83644822B578E/x/y/$i">$i</a> <br>' >> ty.html

If that's where the files are located.

NOTE: Linking to the files will still require a visitor to right-click and select the appropriate item to download the file (On Firefox it's "Save link as...")
I'll need to remember how to make the link be a "download link"...I know I've done that...
Ahh (DDG is my friend)

Code:

echo '<a href="/media/norm/83644822B578E/x/y/$i" download="$i">$i</a> <br>' >> ty.html

I thought it work perfect then i realised that some of these files have blank space in there name, so the link does not work.
Is there some line i can add to the script for it to disregarded the blank space. Otherwise it works nice.
Thank You

BW-userx · 09-06-2018, 07:14 PM

single quoting it might help

Code:

userx@manjaroo:~
$ i="go ba"
$ echo \'$i\'
'go ba'

scasey · 09-06-2018, 08:07 PM

Quote:

Originally Posted by BW-userx

single quoting it might help

Code:

userx@manjaroo:~
$ i="go ba"
$ echo \'$i\'
'go ba'

or double quoting the assignment to i

Code:

for i in "*txt"

Please let us know which worked...