BASH -- need help "cleaning up" IF statement

L_Carver · 08-14-2018, 11:04 PM

My script reads as follows

Code:

#!/bin/bash

fg="$1"
route=$(exiftool -XMP:WebStatement "$fg")
if [[ $route ~= "some-website.com" ]]; then
	exiv1 -k -dc "$fg"
	echo "GD-Jpeg Comment removed."
	exit 0
else
	picked=$(echo "$route" | cut -d/ -f3)
	echo -e "Picture file downloaded from $picked.\nNo need to strip the comment field."
	echo "Good bye."
fi

I get SC1009, SC1073, and SC1072 errors. I haven't been researching Shellcheck errors for a while, and I have to admit I'm more than a little lost on those pages.

Any help would be much appreciated.

Carver

ondoho · 08-15-2018, 12:25 AM

i like your honesty.

is this the complete script?

please show us complete command & output for a test run.

pan64 · 08-15-2018, 12:37 AM

yes, please post exactly what is it, otherwise hard to say anything.
But here is one comment:

Code:

if <condition> then
   do_something
   exit 0
# here you ought to write
fi
# there is no else, just
do_something_else

because exit 0 will definitely not allow to go further.

grail · 08-15-2018, 03:49 AM

Well I don't get any of the errors you have listed from shellcheck.

The first I do get is that ~= is in the wrong order (maybe a typo) and should be =~

Once this is corrected the only issues are the regex which should be unquoted otherwise taken as a literal, which may be what you wanted.
Then the last is to add an additional backslash for your newline as \n is escaping the 'n' inside quotes so more correct to use \\n to escape the backslash to be an actual backslash

This leads me to be the same as the others in that you need to provide more details and perhaps the full script and arguments being passed in