[SOLVED] Answered.

hazyy12 · 11-27-2017, 07:19 AM

This question has been answered thank you for your time.

MadeInGermany · 11-27-2017, 08:10 AM

First of all the `ls /etc/*conf` involves an external command and expands any directories.

Simpler is /etc/*conf
and a test for a file.

Then, $i should be in quotes, otherwise the shell tries expansions on it.

Last but not least, each loop cycle creates a new redirection, overwriting the previous file. Finally the file contains the last wc -l result. But certainly you want all the results. A simple and efficient method is to redirect the whole loop (i.e. all output from within the loop goes to the file)

Code:

for i in /etc/*conf
do
  # it's a file, otherwise jump to next loop cycle
  [ -f "$i" ] || continue
  wc -l "$i"
done > /pleasework.txt

hazyy12 · 11-27-2017, 06:58 PM

Thank you!

It worked!

Keith Hedger · 11-27-2017, 07:18 PM

For clarity you should use the $() construct rather than backticks ` as its easy to mistake a backtick for a single quote, especially when you are begining, the $() is also posix correct but can't be used ( normally ) in a Makefile for instance.

Keith Hedger · 11-27-2017, 07:25 PM

Mark your thread solved with the thread tools, don't delete the original query or change the post title unless requested to do so, iits very bad mannered as other people may have had the same problem as you and now wont find the soulution whilst searching the forums

hazyy12 · 11-27-2017, 08:48 PM

Quote:

Originally Posted by Keith Hedger

Mark your thread solved with the thread tools, don't delete the original query or change the post title unless requested to do so, iits very bad mannered as other people may have had the same problem as you and now wont find the soulution whilst searching the forums

I don't understand forum etiquette yet, I won't make that mistake again.

My thinking behind the decision was I didn't want anyone to waste their time solving a problem that was fixed but I should of looked properly for thread solved instead of deleting sorry about that, for future posts I will not delete any contents I will just mark as solved.

jamison20000e · 11-27-2017, 09:41 PM

The edit leaves a history of the original text so you may fix it‽

!!! · 11-29-2017, 01:46 AM

If you click on #1's blue-underlined Last edited by hazyy12; ...day at 0x:14 PM.
You will see the 'Post Edit History', which you can use, to restore your original post, to help future readers.

Welcome to LQ!!! No big harm on missing a procedural technicality on first try

(There may be a bit of 'extra' sensitivity @LQ because of other UNrelated posters hiding (covering-up) stuff, rendering the responses mysterious)

JJJCR · 11-29-2017, 02:18 AM

Quote:

Originally Posted by MadeInGermany

First of all the `ls /etc/*conf` involves an external command and expands any directories.

Simpler is /etc/*conf
and a test for a file.

Then, $i should be in quotes, otherwise the shell tries expansions on it.

Last but not least, each loop cycle creates a new redirection, overwriting the previous file. Finally the file contains the last wc -l result. But certainly you want all the results. A simple and efficient method is to redirect the whole loop (i.e. all output from within the loop goes to the file)

Code:

for i in /etc/*conf
do
  # it's a file, otherwise jump to next loop cycle
  [ -f "$i" ] || continue
  wc -l "$i"
done > /pleasework.txt

Sorry for this noob question, what do you mean by this ==> "Then, $i should be in quotes, otherwise the shell tries expansions on it."

What's the consequences if it's not in quotes?

Thanks.

pan64 · 11-29-2017, 02:50 AM

Quote:

Originally Posted by hazyy12

I don't understand forum etiquette yet, I won't make that mistake again.

First of all, do not remove your original post.

JJJCR · 11-29-2017, 02:56 AM

Quote:

Originally Posted by pan64

First of all, do not remove your original post.

Agree, it doesn't make sense to remove the original post. It will be super confusing for future readers. Like WTH, readers will not be able to follow the whole thread.

It's like an email without a subject.

MadeInGermany · 11-29-2017, 04:52 AM

$i should be in quotes, because
1. the shell splits on whitespace including newline (by default, tunable with IFS)

Code:

i="two        words"
j="two
lines"
echo $i
two words
echo $j
two lines

but not if the argument is a "string"

Code:

echo "$i"
two        words
echo "$j"
two
lines

2. the shell globs against files in the current directory

Code:

cd /
i=*
echo $i
bin boot cc dev env etc ftp home lib lib64 ...

but not if the argument is a "string"

Code:

echo "$i"
*