Script doesn't recognize wierd characters

webaccounts · 05-23-2008, 07:55 AM

Hopefully someone knows whats wrong with this script. I have a game server that basically deletes any player files that haven't been modified in atleast 90 days.

Code:

#!/bin/sh
# Running this script will remove all player files older than 90 days.
echo ;date
echo "Cleaning up 90 day old player files....."
find -type f -mtime +90
# Actual deletion:
find -type f -mtime +90 -name "*.bic" -exec rm -f {} \;
echo "Cleaning is done."

It works except people with funny names don't work.
For an example:

Code:

./Art?_?miS/?_?artemide?_?.bic

Just wanted to see if there is a way for the above script to catch these wierd characters.

Thanks
Klesla

unSpawn · 05-23-2008, 08:20 AM

Instead have 'find' -printf the inode of the file?

webaccounts · 05-23-2008, 08:28 AM

Quote:

Originally Posted by unSpawn

Instead have 'find' -printf the inode of the file?

What do you mean by that?

Sorry, just learning scripting. The help file says -printf FORMAT but doesn't say what it does or how to add it.

unSpawn · 05-23-2008, 08:40 AM

Something like 'find -type f -mtime +90 -name "*.bic" -printf "%i\n" | xargs -iI find -inum 'I' -exec rm {} \;'.

jschiwal · 05-23-2008, 10:04 AM

Would it work if you enclosed the braces in single quotes:

Code:

find -type f -mtime +90 -name "*.bic" -exec rm -f '{}' \;

Another option is to use the NULL character to separate arguments:

Code:

find -type f -mtime +90 -name "*.bic" -print0 | xargs -0 rm -f

webaccounts · 05-23-2008, 12:34 PM

Thanks for the posts. However all 3 didn't work.

unSpawn · 05-24-2008, 11:26 AM

Quote:

Originally Posted by webaccounts

all 3 didn't work.

"Didn't work" is not the kind of output I can deal with.
Try posting exactly what the command returns instead.

webaccounts · 05-27-2008, 09:29 AM

Sorry. It just doesn't do anything new. But here is the output.

Code:

[root@mars servervault]# find -type f -mtime +90
./Art?_?miS/?_?artemide?_?.bic
./The DC DC/??z?58555g.bic
./The DC DC/?c?7?z15r554.bic
./The DC DC/?z???hn8.bic
./The DC DC/c??0a.bic
./Alastorgame/?r?__kll.bic
./Alastorgame/?r?kll6.bic
./Alastorgame/?r?kll5.bic
./Alastorgame/?rnkillh?h.bic
./Alastorgame/?r?kll.bic
[root@mars servervault]# find -type f -mtime +90 -name "*.bic" -printf "%i\n" | xargs -iI find -inum 'I' -exec rm {} \;
[root@mars servervault]# find -type f -mtime +90
./Art?_?miS/?_?artemide?_?.bic
./The DC DC/??z?58555g.bic
./The DC DC/?c?7?z15r554.bic
./The DC DC/?z???hn8.bic
./The DC DC/c??0a.bic
./Alastorgame/?r?__kll.bic
./Alastorgame/?r?kll6.bic
./Alastorgame/?r?kll5.bic
./Alastorgame/?rnkillh?h.bic
./Alastorgame/?r?kll.bic
[root@mars servervault]#

All 3 scripts I tried and all 3 didn't get those wierd ones.

unSpawn · 05-27-2008, 11:18 AM

Can you at least "find -inum $inode -exec rm {} \;" manually, where "$inode" is one of the inode numbers from running "find -type f -mtime +90 -name "*.bic" -printf "%i\n"? What is your locale? Does "find -type f -mtime +90 -name "*.bic" -print0 | xargs -0 -iX /bin/ls --quoting-style=c --show-control-chars -1iQ 'X'" show different output from what you posted above?

webaccounts · 05-27-2008, 12:37 PM

Quote:

Originally Posted by unSpawn

Can you at least "find -inum $inode -exec rm {} \;" manually, where "$inode" is one of the inode numbers from running "find -type f -mtime +90 -name "*.bic" -printf "%i\n"? What is your locale? Does "find -type f -mtime +90 -name "*.bic" -print0 | xargs -0 -iX /bin/ls --quoting-style=c --show-control-chars -1iQ 'X'" show different output from what you posted above?

I tried your above command but it didn't them either. I did find out something though.

The -name "*.bic" isn't finding them.

Code:

[root@mars servervault]# find -type f -mtime +90
./Art?_?miS/?_?artemide?_?.bic
./The DC DC/??z?58555g.bic
./The DC DC/?c?7?z15r554.bic
./The DC DC/?z???hn8.bic
./The DC DC/c??0a.bic
./Alastorgame/?r?__kll.bic
./Alastorgame/?r?kll6.bic
./Alastorgame/?r?kll5.bic
./Alastorgame/?rnkillh?h.bic
./Alastorgame/?r?kll.bic
[root@mars servervault]# find -type f -mtime +90 -name "*.bic"
[root@mars servervault]#

So I wonder why * isn't treated as a wild card like it should be.

Tinkster · 05-27-2008, 01:15 PM

Have you tried a

Code:

find -type f -mtime +90  -exec rm -f '{}' \;

?

It should be sane since in your search for that mtime only bic
with funny characters showed up...

Cheers,
Tink

webaccounts · 05-27-2008, 01:57 PM

Quote:

Originally Posted by Tinkster

Have you tried a

Code:

find -type f -mtime +90  -exec rm -f '{}' \;

?

It should be sane since in your search for that mtime only bic
with funny characters showed up...

Cheers,
Tink

That does work. I was just hoping to keep it to bic files only because sometimes I keep backup player files there. It seems I might have to resort to that though unless I can get this to work.