Hi, I've been trying to make this simple text menu bash script to mount the computer Zero1's shares. When I run this program and I choose ONE0, it works fine. When I run this program and choose any other choice, it still mounts ONE0.

Here is the script, file is called "mount":

#!/bin/bash
echo "What would you like to mount?"
echo
OPTIONS="ONE0 Music Downloads SharedDocs"
select MOUNT in $OPTIONS; do
if [ "$MOUNT"="ONE0" ]; then
mount -t smbfs -o guest //zero1/ONE0\ \(D\) /mnt/zero1/ONE0
echo Mounted ONE0
exit
elif [ "$MOUNT"="Music" ]; then
mount -t smbfs -o guest //zero1/My\ Music /mnt/zero1/Music
echo Mounted Music
exit
elif [ $MOUNT="Downloads" ]; then
mount -t smbfs -o guest //zero1/Downloads /mnt/zero1/Downloads
echo Mounted Downloads
exit
elif [ $MOUNT="SharedDocs" ]; then
mount -t smbfs -o guest //zero1/SharedDocs /mnt/zero1/SharedDocs
echo Mounted SharedDocs
exit
else
echo Not valid share
exit
fi
done



Here are some outcomes:

root @ obelisk :: /mnt/zero1 >> ./mount
What would you like to mount?

1) ONE0
2) Music
3) Downloads
4) SharedDocs
#? 1
Mounted ONE0
root @ obelisk :: /mnt/zero1 >> ./mount
What would you like to mount?

1) ONE0
2) Music
3) Downloads
4) SharedDocs
#? 2
Mounted ONE0
root @ obelisk :: /mnt/zero1 >>


ONE0 is mounted successfully, but the others aren't. Any help would be greatly appreciated.

Try putting spaces around "=" in your comparisons. You'll find it works much better.

Just out of curiosity, why not use "case"?

Mike

And why do you have exit's after every single mount? That most likely is your problem, you have an exit right after the first mount so the rest of your script is never being executed.

You're right that they're redundant, but not that they're part of the problem. The if .. elif .. elif .. else logic ensures that only one mount will be executed. I would expect this to be the OP's aim, otherwise you'd only need four mount commands.

The problem is that because there are no spaces around the "=" bash interpret's the comparison as an assignment and returns TRUE in the first comparison no matter what the input is.

Mike

i added the spaces and it worked, thanks everyone who replied

if in the future you wish to debug your scripts then add -x to #!/bin/bash


#!/bin/bash -x

What does the -x do? I don't see that in "man bash".

it will run the entire script in debug mode

http://www.tldp.org/LDP/Bash-Beginne...ect_02_03.html

Thanks