Quote:
Originally Posted by someguydude
As I Said I am giving up ...
... but if someone can answer my thread question ...
... I will continue work.
|
Of course do what you think is best, but I think the project is worth the effort to fix it. I compiled my executable from main.c and ran it to create my scripts. No problem. I have not downloaded the package set and tried the scripts yet, but I did read through them and have some things for you to consider.
One is that I think it is bad practice to do second passes without deleting the entire package directory from the first pass and untarring it again for the second pass. This may even be behind the Libstdc++ problems in your other thread. Anyway, the book's
General Compilation Instructions say to "delete the extracted source directory unless instructed otherwise", and I cannot find any package that instructs "otherwise".
Some other little things...
1.Lines 891-895 in the step 3 script are not commands and will stop the script.
2. Line 2974 in the step 6 script needs a test to set ABI=32 or not for the configure command. Otherwise this line will stop the script as it is now.
3. Line 3652 in the step 6 script (passwd root) will stop the script for user input. In my own scripts, I install Shadow here as per the book, but I move this passwd command to the end of the script for this part of the book. Or you could omit the passwd root command in the script and simply echo a comment at the end telling the user to run the command before exiting the session.
4. Line 2672 in the step 7 script requires user input. Figure out some way to set the PAGE parameter for Groff.
5. The step 7 script effectively ends at a logout and re-entry into chroot. It probably needs some kind of echo comment regarding successful completion and what the user should do next to finish up (the configuration and kernel stuff manually).
Anyway, that's my two cents for now. BTW, did you know that a checkout of the development book at git-hub has a makefile option called dump-commands that will essentially produce what your program does. It's very handy for a script builder. And if the checkout is done right before or after a stable release, there probably will be few or no changes needed.