LinuxQuestions.org
Help answer threads with 0 replies.
Go Back   LinuxQuestions.org > Forums > Non-*NIX Forums > General
User Name
Password
General This forum is for non-technical general discussion which can include both Linux and non-Linux topics. Have fun!

Notices


Reply
  Search this Thread
Old 02-04-2019, 08:36 PM   #1
Jason_25
Member
 
Registered: Nov 2001
Posts: 77

Rep: Reputation: 15
Github is unable to properly rotate images: what kind of challenges could they be facing?


For years now, Github's code preview features and wiki have been unable to deal with image EXIF data. This means that often images are turned the wrong way.

In addition, their internal "markup" language has no mechanism to rotate an image.

For me personally 100% of my images are turned the wrong way in Github. Yet 100% of my images work correctly on 100% of my computers.

The conspiracy theorist idea I have is that they want all projects to look as unprofessional as possible. After all, if all your images are flipped no one is going to take your work seriously. Maybe you can then "buy in" to actually have working images.

What kind of issues could they be facing in implementing something so simple?

Finally, are competing services like Gitlab handling image orientation correctly?

It would be a lot of work to move my project around but if that is what it takes to look professional then maybe I can live with that.
 
Old 02-04-2019, 10:01 PM   #2
ntubski
Senior Member
 
Registered: Nov 2005
Distribution: Debian, Arch
Posts: 3,404

Rep: Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593Reputation: 1593
Quote:
Originally Posted by Jason_25 View Post
What kind of issues could they be facing in implementing something so simple?
Nobody is paying them to implement it correctly.
 
Old 02-04-2019, 11:17 PM   #3
syg00
LQ Veteran
 
Registered: Aug 2003
Location: Australia
Distribution: Lots ...
Posts: 17,519

Rep: Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744Reputation: 2744
I'm betting Linus didn't give a damn about images during the BitKeeper furore - maybe the sentiment continues.
 
Old 02-04-2019, 11:28 PM   #4
dugan
LQ Guru
 
Registered: Nov 2003
Location: Canada
Distribution: Slackware
Posts: 8,686

Rep: Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702
Quote:
Originally Posted by Jason_25 View Post
What kind of issues could they be facing in implementing something so simple?
Honestly, I'm going to go with "they didn't think it was causing anyone problems".

I've never had that problem myself, I don't know anyone who did, and when I googled for it this is the only hit I got:

https://stackoverflow.com/q/19434073/240515

Send them a support email.

EDIT: Also found this.

https://github.com/github/markup/issues/1140

EDIT: And this:

https://www.daveperrett.com/articles...g-is-a-ghetto/

Last edited by dugan; 02-04-2019 at 11:33 PM.
 
Old 02-05-2019, 03:23 AM   #5
ondoho
LQ Addict
 
Registered: Dec 2013
Posts: 10,763
Blog Entries: 7

Rep: Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694Reputation: 2694
Quote:
Originally Posted by Jason_25 View Post
For years now, Github's code preview features and wiki have been unable to deal with image EXIF data. This means that often images are turned the wrong way.

In addition, their internal "markup" language has no mechanism to rotate an image.

For me personally 100% of my images are turned the wrong way in Github. Yet 100% of my images work correctly on 100% of my computers.

The conspiracy theorist idea I have is that they want all projects to look as unprofessional as possible. After all, if all your images are flipped no one is going to take your work seriously. Maybe you can then "buy in" to actually have working images.

What kind of issues could they be facing in implementing something so simple?

Finally, are competing services like Gitlab handling image orientation correctly?

It would be a lot of work to move my project around but if that is what it takes to look professional then maybe I can live with that.
conspiracy theory?
i think this explanation is much more likely:
Quote:
Originally Posted by dugan View Post
 
Old 02-05-2019, 03:28 AM   #6
NevemTeve
Senior Member
 
Registered: Oct 2011
Location: Budapest
Distribution: Debian/GNU/Linux, AIX
Posts: 3,671

Rep: Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142
You will laugh at me, but so far I had no idea that Github was an image-manipulating system; I thought it was a public git-repository.
 
Old 02-05-2019, 04:36 AM   #7
astrogeek
Moderator
 
Registered: Oct 2008
Distribution: Slackware [64]-X.{0|1|2|37|-current} ::12<=X<=14, FreeBSD_10{.0|.1|.2}
Posts: 4,925
Blog Entries: 8

Rep: Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798Reputation: 2798
Moved: This thread is more suitable in General forum and has been moved accordingly to help your thread/question get the exposure it deserves.
 
Old 02-06-2019, 09:36 AM   #8
Jason_25
Member
 
Registered: Nov 2001
Posts: 77

Original Poster
Rep: Reputation: 15
Thanks for moving this to the appropriate place. I could not decide where to put it.

I did read over that stackoverflow thread already and it boiled down to manually rotating the image in an editor program. This bothers me because it should work as-is.

I had also read the Github thread already and to me it seemed like the problem was being swept under the rug by Github. I figured more exposure of the problem on this site could not hurt.

I just now skimmed the "EXIF Orientation is a ghetto" link and it looks like the best way for Github to handle it is to provide some kind of toggle option for "Use EXIF Orientation".

NevemTeve - here are some examples of where images could be used on a code website:
You have made a mod for a game and want to post a screenshot
You have made a hardware device that also includes code and want to include an image of the device
You have an elaborate procedure best described in a flow chart-like or wiring-like diagram

I also already sent a support e-mail to Github a while back but I was fuming mad about the problem as I always am after posting a new project. So they probably did not receive it well. The workflow usually is:

1. Work hard on a project a long time
2. Take a carefully crafted image of the final product
3. Post the work including images
4. See the images are flipped the wrong way
5. Fly into a rage/depression

Anyway maybe this will help give the problem the exposure it needs for them to do something about it.
 
Old 02-06-2019, 12:39 PM   #9
dugan
LQ Guru
 
Registered: Nov 2003
Location: Canada
Distribution: Slackware
Posts: 8,686

Rep: Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702
If all your images are rotated wrong in the same way, then just batch-fix them all with ImageMagick before uploading them.

Last edited by dugan; 02-06-2019 at 05:15 PM.
 
Old 02-07-2019, 03:50 AM   #10
NevemTeve
Senior Member
 
Registered: Oct 2011
Location: Budapest
Distribution: Debian/GNU/Linux, AIX
Posts: 3,671

Rep: Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142Reputation: 1142
So what exactly the problem is?
1. You wish Github would rotate images, but it doesn't.
2. You wish Github wouldn't rotate images, but it does.
 
Old 02-07-2019, 11:52 PM   #11
Myk267
Member
 
Registered: Apr 2012
Location: California
Posts: 416
Blog Entries: 15

Rep: Reputation: Disabled
Sometimes, using simpler libraries is a security blessing.

No conspiracy necessary. Feel free to start "rotated-images-hub" and rake it in, though.
 
Old 02-08-2019, 06:31 PM   #12
dugan
LQ Guru
 
Registered: Nov 2003
Location: Canada
Distribution: Slackware
Posts: 8,686

Rep: Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702
Quote:
Originally Posted by Jason_25 View Post
2. Take a carefully crafted image of the final product
3. Post the work including images
Would this be a more honest description of what you actually did?

1. take a photograph
2. upload the photograph (unmodified)

Quote:
NevemTeve - here are some examples of where images could be used on a code website:
You have made a mod for a game and want to post a screenshot
You have made a hardware device that also includes code and want to include an image of the device
You have an elaborate procedure best described in a flow chart-like or wiring-like diagram
Most of these wouldn't be photographs and thus wouldn't depend on exif tags for orientation though.

Last edited by dugan; 02-08-2019 at 06:40 PM.
 
Old 02-08-2019, 09:43 PM   #13
Jason_25
Member
 
Registered: Nov 2001
Posts: 77

Original Poster
Rep: Reputation: 15
Quote:
Originally Posted by dugan View Post
Would this be a more honest description of what you actually did?

1. take a photograph
2. upload the photograph (unmodified)



Most of these wouldn't be photographs and thus wouldn't depend on exif tags for orientation though.
I am not a photographer. Just getting the image steady would qualify for me as "carefully crafted". If someone wants to pay me to do to work to update the images I am all for it.

Frankly it's a bit of a chicken and egg problem. I am not going to do a bunch of work to images so that 10 or 15 people can get satisfaction from it. And I am only ever going to have 10 or 15 people look at it because the images are flipped.

I don't buy that expanding their already extensive codebase for this is going to be a significant security problem.

I know about using imagemagick for bulk image editing. But I am sticking to my guns on this. Apparently what I have created is not that great. If one day I can build something world changing and the images are still upside down then Github's lazy people will be FORCED to fix the problem.

More great news: as of today, Github's "insights" feature only works on Microsoft-sanctioned browser platforms. Attempts to defeat it with browser user agent spoofing have failed. I would start another thread but instead we can pile all our disdain on Github in this one instead.
 
Old 02-08-2019, 09:51 PM   #14
dugan
LQ Guru
 
Registered: Nov 2003
Location: Canada
Distribution: Slackware
Posts: 8,686

Rep: Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702Reputation: 3702
Make a contribution to get it working in GitLab, if you want to create a service that doesn't have this problem.

Last edited by dugan; 02-08-2019 at 10:04 PM.
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
LXer: Learn to use GitHub with GitHub Learning Lab LXer Syndicated Linux News 0 04-20-2018 02:12 AM
LXer: GitHub wants more new contributors, because that's what GitHub is for LXer Syndicated Linux News 0 07-27-2017 07:36 AM
Log rotate not rotate newFreeBSD Linux - Server 13 09-12-2013 09:59 PM
Rotate display -- Option "Rotate" "CCW" Brad.Scalio@noaa.gov Linux - General 0 01-27-2009 06:32 AM
LXer: Five Challenges Facing Sun-MySQL Deal LXer Syndicated Linux News 0 01-17-2008 04:20 AM

LinuxQuestions.org > Forums > Non-*NIX Forums > General

All times are GMT -5. The time now is 09:24 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration