You're welcome and I'm glad you have a use for it.
It was quite satisfying to get something I'd written adopted by the devs.
Like you I used to run with 2 volume groups back on 12.1/2 (a vgdata and a vgsystem) and I had the same issue, namely that /etc/rc.d/rc.S does the lvm vgscan before /etc/crypttab processing so if you have additional luks encrypted PVs that are unlocked via crypttab then they're not available when the vgscan is run so it doesn't detect the second volume group and you get failures to mount filesystems from the 'mount -a'.
rc.S still has that issue and could probably do with having 2 runs of cryptsetup in a similar way to how initrd now works. I did send an updated rc.S which catered for a second pass at the crypttab to Pat just before 12.2 released but the code was a little convoluted and not nearly as elegant as what I came up with for the initrd. He didn't adopt it in the end - which was probably the correct choice on that occasion.
If I ever get around to it, I might take another look at rc.S and see what I can do to make it better, but since my new box only has a single volume group, and the initrd can now unlock any additional disks anyway there's no great need.