[SOLVED] Grub mkconfig fails to run: "unterminated `s' command"

murdo · 01-25-2022, 03:13 AM

Pretty much the title; I updated my kernel with the most recent Slackware Current changes, tried running

Code:

grub-mkconfig -o /boot/grub/grub.cfg

to refresh grub, and I get the error

Code:

sed: -e expression #1, char 11: unterminated `s' command

Never had something like this happen before, grub's always worked. I'm now worried if I shut down my system I won't be able to boot it again.

teoberi · 01-25-2022, 04:00 AM

Without running

Code:

grub-mkconfig -o /boot/grub/grub.cfg

my systems boot with the latest kernel update (Upgraded ? Rebuilt).
If you use symbolic links, the previous command is not required, especially if you have manually modified the file grub.cfg.

marav · 01-25-2022, 04:19 AM

Quote:

Originally Posted by murdo

Pretty much the title; I updated my kernel with the most recent Slackware Current changes, tried running

Code:

grub-mkconfig -o /boot/grub/grub.cfg

to refresh grub, and I get the error

Code:

sed: -e expression #1, char 11: unterminated `s' command

Never had something like this happen before, grub's always worked. I'm now worried if I shut down my system I won't be able to boot it again.

Can you post your /etc/default/grub ?

murdo · 01-25-2022, 08:30 AM

Quote:

Originally Posted by teoberi

Without running

Code:

grub-mkconfig -o /boot/grub/grub.cfg

my systems boot with the latest kernel update (Upgraded ? Rebuilt).
If you use symbolic links, the previous command is not required, especially if you have manually modified the file grub.cfg.

That's interesting. In the past I've failed to run that command after upgrading the kernel and Current hasn't booted; I had to log in to 14.2 and re-run the command from there, after which Current was able to boot.

I haven't manually modified grub.cfg, since it says not to in the file and I don't know how the stuff in there works.

Quote:

Originally Posted by marav

Can you post your /etc/default/grub ?

Yep! Contents here:

Code:

# If you change this file, run grub-mkconfig -o /boot/grub/grub.cfg
# afterwards to update /boot/grub/grub.cfg.

GRUB_DEFAULT="Slackware-15.0 GNU/Linux"
#GRUB_HIDDEN_TIMEOUT="0"
GRUB_HIDDEN_TIMEOUT_QUIET="false"
GRUB_TIMEOUT="10"
GRUB_DISTRIBUTOR="$( sed s/Slackware /Slackware-/ /etc/slackware-version )"
GRUB_CMDLINE_LINUX_DEFAULT=""
GRUB_CMDLINE_LINUX=""

# Uncomment to disable graphical terminal (grub-pc only)
#GRUB_TERMINAL="console"

# The resolution used on graphical terminal
# note that you can use only modes which your graphic card supports via VBE
# you can see them in real GRUB with the command `vbeinfo'
#GRUB_GFXMODE="640x480"
#GRUB_GFXMODE="1024x768x32"

# Font used on the graphical terminal:

# Uncomment if you don't want GRUB to pass "root=UUID=xxx" parameter to Linux
#GRUB_DISABLE_LINUX_UUID="true"

# Uncomment to disable generation of recovery mode menu entries
#GRUB_DISABLE_RECOVERY="true"

GRUB_DISABLE_OS_PROBER="false"

GRUB_SAVEDEFAULT="false"
GRUB_FONT="/boot/grub/unicode.pf2"

There's also a grub.new, I just noticed -- here are the contents for it:

Code:

# If you change this file, run grub-mkconfig -o /boot/grub/grub.cfg
# afterwards to update /boot/grub/grub.cfg.

GRUB_DEFAULT=0
#GRUB_HIDDEN_TIMEOUT=0
GRUB_HIDDEN_TIMEOUT_QUIET=false
GRUB_TIMEOUT=10
GRUB_DISTRIBUTOR=$( sed 's/Slackware /Slackware-/' /etc/slackware-version )
GRUB_CMDLINE_LINUX_DEFAULT=""
GRUB_CMDLINE_LINUX=""

# Uncomment to disable graphical terminal (grub-pc only)
#GRUB_TERMINAL=console

# The resolution used on graphical terminal
# note that you can use only modes which your graphic card supports via VBE
# you can see them in real GRUB with the command `vbeinfo'
#GRUB_GFXMODE=640x480
#GRUB_GFXMODE=1024x768x32

# Font used on the graphical terminal:
#GRUB_FONT=/usr/share/grub/dejavusansmono.pf2

# Uncomment if you don't want GRUB to pass "root=UUID=xxx" parameter to Linux
#GRUB_DISABLE_LINUX_UUID=true

# Uncomment to disable generation of recovery mode menu entries
#GRUB_DISABLE_RECOVERY="true"

giomat · 01-25-2022, 08:42 AM

check the line with

Code:

GRUB_DISTRIBUTOR=...

there's a syntax difference for sed with the .new file

marav · 01-25-2022, 08:43 AM

Quote:

Originally Posted by murdo

That's interesting. In the past I've failed to run that command after upgrading the kernel and Current hasn't booted; I had to log in to 14.2 and re-run the command from there, after which Current was able to boot.

I haven't manually modified grub.cfg, since it says not to in the file and I don't know how the stuff in there works.

in your /etc/default/grub

Code:

GRUB_DISTRIBUTOR="$( sed s/Slackware /Slackware-/ /etc/slackware-version )"

should be - with the simple quotes -

Code:

GRUB_DISTRIBUTOR=$( sed 's/Slackware /Slackware-/' /etc/slackware-version )

marav · 01-25-2022, 09:59 AM

Comment in my "reputation popup" (not very visible, but thanks anyway)

Code:

Fixed my issue cleanly and simply

Good

feel free to mark this thread as solved ;-)

note: I didn't notice you were from Scotland. I have a couple of malt-based ideas if you want to give me a favor.