[SOLVED] broken fzf build script (?)

Marshall_Banana · 10-22-2023, 07:24 PM

I have been having trouble attempting to install fzf from SBo. Here is the output error I receive whenever I try to install it.

Code:

zf-0.42.0/src/tui/tui_test.go
fzf-0.42.0/src/util/
fzf-0.42.0/src/util/atomicbool.go
fzf-0.42.0/src/util/atomicbool_test.go
fzf-0.42.0/src/util/chars.go
fzf-0.42.0/src/util/chars_test.go
fzf-0.42.0/src/util/eventbox.go
fzf-0.42.0/src/util/eventbox_test.go
fzf-0.42.0/src/util/slab.go
fzf-0.42.0/src/util/util.go
fzf-0.42.0/src/util/util_test.go
fzf-0.42.0/src/util/util_unix.go
fzf-0.42.0/src/util/util_windows.go
fzf-0.42.0/test/
fzf-0.42.0/test/fzf.vader
fzf-0.42.0/test/test_go.rb
fzf-0.42.0/typos.toml
fzf-0.42.0/uninstall
fatal: not a git repository (or any of the parent directories): .git
GOARCH=amd64 go build -a -ldflags "-s -w -X main.version=0.42.0 -X main.revision=Slackware" -tags "" -mod=vendor -o target/fzf-gccgo_amd64
main.go:4:2: //go:build comment without // +build comment
main.go:5:2: //go:build comment without // +build comment
src/ansi.go:8:2: //go:build comment without // +build comment
src/algo/algo.go:88:2: //go:build comment without // +build comment
vendor/github.com/mattn/go-runewidth/runewidth.go:7:2: //go:build comment without // +build comment
make: *** [Makefile:136: target/fzf-gccgo_amd64] Error 1
Failure encountered while building fzf:
  fzf.SlackBuild return non-zero

Has anyone else experienced this before? I tried to check the thread broken SBo scripts, but there seems to be a lot to go through.
I apologize in advance if this post is a bit bare on details, this is the first time I've encountered a problem of this nature regarding SBo/slack-builds, but I'm happy to provide any relevant details upon inquiry, as necessary.

EDIT:
Attempted to install with both SBO['15.0']=https://www.slackbuilds.org/slackbuilds/15.0/ and SBO['current']=https://cgit.ponce.cc/slackbuilds/ repo's, both of which produced same error as shown above, by uncommenting one line running

Code:

$slackpkg update
$sboinstall fzf

and repeating vice versa with the other line.

The go-lang dependency is satisfied as well.

quickbreakfast · 10-22-2023, 09:45 PM

Since you don't say which way you tried to install fzf, or indicate whether you are using current or stable (and if stable which stable) there is not really much I can suggest to you.

However I am curious to know whether you read the slackbuilds info about fzf, which clearly states that fzf which requires a dependent to be installed first.

Marshall_Banana · 10-22-2023, 11:20 PM

Quote:

Originally Posted by quickbreakfast

Since you don't say which way you tried to install fzf, or indicate whether you are using current or stable (and if stable which stable) there is not really much I can suggest to you.

However I am curious to know whether you read the slackbuilds info about fzf, which clearly states that fzf which requires a dependent to be installed first.

I tried to install through both the sbopkg ncurses menu, as well as with sboinstall, both of which yielded the exact same error.
I also tried to install from both current and stable, which I believe the proper way to do is through un-commenting one of the following lines in slackpkgplus.conf,

SBO['15.0']=https://www.slackbuilds.org/slackbuilds/15.0/
SBO['current']=https://cgit.ponce.cc/slackbuilds/

running $slackpkg update, then $sboinstall fzf, and then repeating the same process with the un-commenting done in vice versa between the two lines.

And yes, I'm aware that it requires go-lang 1.18 or greater as a dependency; of which I currently have go-lang 1.20 installed.
And as a bonus, I also have slackpkgplus.conf currently configured with PKGS_PRIORITY=( multilib ), if that makes a difference, although I don't think it should.

ponce · 10-23-2023, 12:26 AM

installing google-go-lang is not enough: you have to logout and login again from your root shell (or use "su -l") so that the appropriate files in /etc/profile.d are sourced and the new go compiler is used, it's explained in google-go-lang's README (you're supposed to read the READMEs of stuff you install from SBo).
I say this because from the log you posted you still seem to use the go compiler from gcc.

Marshall_Banana · 10-25-2023, 02:14 AM

Quote:

Originally Posted by ponce

installing google-go-lang is not enough: you have to logout and login again from your root shell (or use "su -l") so that the appropriate files in /etc/profile.d are sourced and the new go compiler is used, it's explained in google-go-lang's README (you're supposed to read the READMEs of stuff you install from SBo).
I say this because from the log you posted you still seem to use the go compiler from gcc.

The $su -l seems to have done the trick. You claimed that the compiler is mentioned in the google-go-lang READ-ME but I saw no such thing, unless we are referring to different READ-ME's. Here is the READ-ME from my /usr/doc/google-go-lang-1.20.5/README.md

Code:

# The Go Programming Language

Go is an open source programming language that makes it easy to build simple,
reliable, and efficient software.

![Gopher image](https://golang.org/doc/gopher/fiveyears.jpg)
*Gopher image by [Renee French][rf], licensed under [Creative Commons 4.0 Attributions license][cc4-by].*

Our canonical Git repository is located at https://go.googlesource.com/go.
There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the
BSD-style license found in the LICENSE file.

### Download and Install

#### Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install
for installation instructions.

#### Install From Source

If a binary distribution is not available for your combination of
operating system and architecture, visit
https://go.dev/doc/install/source
for source installation instructions.

### Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and
proposals only. See https://go.dev/wiki/Questions for a list of
places to ask questions about the Go language.

[rf]: https://reneefrench.blogspot.com/
[cc4-by]: https://creativecommons.org/licenses/by/4.0/

Are there any specific files in profile.d I should be giving particular attention to where this compiler configuration occurs?

Tonus · 10-25-2023, 04:11 AM

He was speaking of the README in the SlackBuild directory of google-go-lang.

Quote:

The tools are added to the path by putting go.sh and go.csh files in
/etc/profile.d and letting the system's /etc/profile or /etc/csh.login
pick it up.

I agree, could be more explicit.

We had a chat on the mailing list about the opportunity to source the changed path in SlackBuilds depending on google-go-lang with no decision AFAIK.

ponce · 10-25-2023, 05:03 AM

FWIW, the need to use "su -l" instead of the plain "su" is explained also in the main HOWTO.

Marshall_Banana · 10-27-2023, 07:59 PM

Welp, with that, I believe it's time to declare this problem solved, mark the thread as "solved," and say thanks to everyone that took the time to respond. Thanks.