[SOLVED] aMule doesn't compile in Slackware 64 stable

PreguntoYo · 07-30-2018, 05:29 AM

I've tried to compile it this morning, using the SlackBuild results in:

Code:

.
.
.
aMule-2.3.1/aMule.app/Contents/Frameworks/libthreadutil.2.dylib
aMule-2.3.1/aMule.app/Contents/Frameworks/libixml.2.dylib
aMule-2.3.1/aMule.app/Contents/SharedSupport/
aMule-2.3.1/aMule.app/Contents/SharedSupport/locale/
patching file src/UPnPBase.cpp
Hunk #1 FAILED at 29.
Hunk #2 succeeded at 1161 (offset 34 lines).
Hunk #3 FAILED at 1149.
Hunk #4 succeeded at 1233 with fuzz 1 (offset 38 lines).
Hunk #5 FAILED at 1216.
Hunk #6 FAILED at 1252.
Hunk #7 FAILED at 1280.
Hunk #8 FAILED at 1321.
Hunk #9 FAILED at 1342.
7 out of 9 hunks FAILED -- saving rejects to file src/UPnPBase.cpp.rej
patching file src/UPnPBase.h
Hunk #1 FAILED at 490.
1 out of 1 hunk FAILED -- saving rejects to file src/UPnPBase.h.rej

aMule:
Would you like to continue processing the rest of the
queue or would you like to abort?  If this failed
package is a dependency of another package in the queue
then it may not make sense to continue.

(Y)es to continue, (N)o to abort, (R)etry the build?:

Which is strange, because I had previously built and installed required dependencies in my system:

cryptopp-5.6.5-x86_64-1_SBo
wxPython-2.8.12.1-x86_64-2_SBo

Am I doing something wrong?

ponce · 07-30-2018, 05:42 AM

have you tried removing libupnp and trying to build it again?

PreguntoYo · 07-30-2018, 06:05 AM

Quote:

Originally Posted by ponce

have you tried removing libupnp and trying to build it again?

I haven't libupnp installed; the SlackBuild doesn't requires it.

ponce · 07-30-2018, 07:08 AM

try removing this line from the SlackBuild

Code:

patch -p1 < $CWD/libupnp-1.8.patch

drgibbon · 07-30-2018, 07:17 AM

Quote:

Originally Posted by PreguntoYo

Code:

7 out of 9 hunks FAILED -- saving rejects to file src/UPnPBase.cpp.rej
patching file src/UPnPBase.h
Hunk #1 FAILED at 490.
1 out of 1 hunk FAILED -- saving rejects to file src/UPnPBase.h.rej

Same build failure for me on Slack 14.2_x86 (with or without libupnp installed).

drgibbon · 07-30-2018, 07:19 AM

Quote:

Originally Posted by ponce

try removing this line from the SlackBuild

Code:

patch -p1 < $CWD/libupnp-1.8.patch

But it builds with this patch line commented out

PreguntoYo · 07-30-2018, 02:42 PM

Quote:

Originally Posted by ponce

try removing this line from the SlackBuild

Code:

patch -p1 < $CWD/libupnp-1.8.patch

Confirmed. It compiles (and runs) in Slackware 64 14.2 stable after editing the SlackBuild and commenting out the patch line.

About why the code first needed to be patched to work and not now is beyond my knowledge...

orbea · 07-30-2018, 02:59 PM

My guess is the patch was added and was somehow never tested or only tested against a different version of aMule. The md5sum still matches what is recorded in the .info file so I doubt the release was changed after the fact.

ponce · 07-31-2018, 02:12 AM

Quote:

Originally Posted by PreguntoYo

About why the code first needed to be patched to work and not now is beyond my knowledge...

it actually needs to be patched against libupnp-1.8.x (that is an optional dependency) but to be honest I forgot what I had done/why I had done it when I committed that (senility is hitting me prematurely!).

I'll just revert the commit.