I have a very simple bash script:

echo -n Create home directory?:
read HOMEDIR

if [ $homedir="y" ] || [ $homedir="yes" ]; then
homeval=" --makehomedir"
else
homeval="none"
fi

echo "the value is = " $homeval

Can someone please explain where my error is...why when echoing homeval (the last line of the script), the value is always --makehomedir, even when answering something other than y or yes?

First, basically everything in Linux (and UNIX in general) is case-sensitive, so you've got to remember that HOMEDIR and homedir are different variables.

Second, without spaces in your comparison (e.g. if you do $homedir="y") that's actually assignment - you're assigning the value "y" to whatever the value of $homedir evaluates to be, and that will always be successful. You have to add spaces (make it $homedir = "y") for it to be treated as a comparison.

3 members found this post helpful.

Thank you!

Rich

DOn't forget to mark as SOLVED once you have your solution

It won't work if your directory name has spaces. Better put the variables inside quotes:

Not sure where you were going here Konsole, but the variable is storing y or yes not the directory name

Oh sorry. I was having too much thinking.. so.. anyway.. I think that will still cause error if he suddenly typed an IFS char.. But of course it can be ignored at preference.

..... I'm losing focus.. obviously. I've been doing many random things lately.. Things that are social related and project related.

Btw, I would always love to have my cybernick in a small letter K with the box attached.

---- edit ----

I just thought,.. maybe a short version would also be nice like konsole' or 'box. ^_^

Just kidding. As if the nick's really that special to have such an honor of being quoted.