[SOLVED] Sending binary data through sockets in C

Carlos2313 · 11-29-2010, 05:00 AM

Hi everyone,

I am coding a http server which has to send the file(s) such as images, .avi files, .mpeg, that the client is going to request.
I have been trying of sending files through sockets .

Quote:

char info [256];
bzero(info, 256);
//memset(&info,0,sizeof(info));

read(socket, info, 255);
write(socket, HTTP, 255);
FILE *fl= fopen(info,"rb");
fseek(fl, 0, SEEK_END);
long len = ftell(fl);
printf("largo: %ld\n", len);
unsigned char *ret = (char*) malloc(len);
fseek(fl, 0, SEEK_SET);
fread(ret, 1, len, fl);

However, it's supposed to be shown in Mozilla Firefox (as the client). But it is not doing it, so.. It's just not getting the complete file...
So, could some please give me a guide?

rupertwh · 11-29-2010, 05:47 AM

Oh boy,

Code:

read(socket, info, 255);

What if the client sends less than or more than 255 bytes?

Code:

write(socket, HTTP, 255);

So HTTP is exactly 255 bytes long?

Code:

FILE *fl= fopen(info,"rb");
fseek(fl, 0, SEEK_END);
long len = ftell(fl);

What if fopen() fails?

Code:

unsigned char *ret = (char*) malloc(len);
fseek(fl, 0, SEEK_SET);
fread(ret, 1, len, fl);

Do you really want/need to read the whole file into a buffer, regardless of its size?

You never send anything back to the client.