[SOLVED] sed

salmanahmed · 04-15-2022, 10:06 AM

Hi
I am using following script to replace certain numbers in my text files.

Code:

#!/bin/bash
sed -i -e 's/2.66666666666667/2/' -i -e 's/3.33333333333333/3/' \
        -i -e 's/4.66666666666667/4/' -i -e 's/5.33333333333333/5/' $1
echo ""
echo "Conversion completed for" $1

However, the disadvantage of this script is I have to enter all the numbers manually in the script which will result in unnecessarily and overwhelmingly large script.
Actually, the basic function which I want to achieve from this script is to remove all the numbers after the decimal point. For example, 2.667 should be converted to 2 and so on.
So, I think there must be a better way to write this script, instead of manually entering the numbers in the script.
Can you guide me towards the right-way to write this script? Thanks

pan64 · 04-15-2022, 10:24 AM

Code:

sed 's/\.[0-9]*//'

salmanahmed · 04-15-2022, 11:15 AM

Quote:

Originally Posted by pan64

Code:

sed 's/\.[0-9]*//'

Thanks a lot. I wasn't expecting that the solution would be so simple :-)

TB0ne · 04-15-2022, 11:15 AM

Quote:

Originally Posted by salmanahmed

Hi
I am using following script to replace certain numbers in my text files.

Code:

#!/bin/bash
sed -i -e 's/2.66666666666667/2/' -i -e 's/3.33333333333333/3/' \
        -i -e 's/4.66666666666667/4/' -i -e 's/5.33333333333333/5/' $1
echo ""
echo "Conversion completed for" $1

However, the disadvantage of this script is I have to enter all the numbers manually in the script which will result in unnecessarily and overwhelmingly large script. Actually, the basic function which I want to achieve from this script is to remove all the numbers after the decimal point. For example, 2.667 should be converted to 2 and so on. So, I think there must be a better way to write this script, instead of manually entering the numbers in the script. Can you guide me towards the right-way to write this script?

pan64 gave a great answer, but I'll ask the question of "why?" How are these numbers getting in to whatever you're 'converting' in the first place?? Be far simpler to do the conversion there, versus later on. And rounding 2.667 to 2 would be rounding down...wouldn't 2.6 round UP to 3?

salmanahmed · 04-15-2022, 11:29 AM

Quote:

Originally Posted by TB0ne

pan64 gave a great answer, but I'll ask the question of "why?" How are these numbers getting in to whatever you're 'converting' in the first place?? Be far simpler to do the conversion there, versus later on. And rounding 2.667 to 2 would be rounding down...wouldn't 2.6 round UP to 3?

The purpose here is just to remove the portion after decimal. It is nothing to do with rounding.

TB0ne · 04-15-2022, 11:42 AM

Quote:

Originally Posted by salmanahmed

The purpose here is just to remove the portion after decimal. It is nothing to do with rounding.

Gotcha....still, it would seem to make more sense to have whatever is outputting these numbers print things the way you want, versus cleaning it up after.

salmanahmed · 04-15-2022, 12:11 PM

Quote:

Originally Posted by TB0ne

Gotcha....still, it would seem to make more sense to have whatever is outputting these numbers print things the way you want, versus cleaning it up after.

The output is being created by Libreoffice calc. I know that we can adjust the output in Cell Properties > Number > Decimal.