my first shell script doesnt work :(

boxerboy · 12-22-2005, 10:50 AM

Code:

#!/bin/sh
# print out the date and who's logged on
date ; who ; #should print date and who is logged on.

that is the script saved as logins.sh used anjuta to write it. when i do chmod a+x logins(.sh) either way either nothing happens and errors but i still cant run it i have tried everyway i can think of to run it its supposed to run with the command logins so i thought. anyone give me a hand with this script please

Nylex · 12-22-2005, 10:56 AM

How are you trying to run it or what kind of errors is it generating? It works fine for me.

boxerboy · 12-22-2005, 11:01 AM

in terminal i type chmod a+x logins and i get that it cant access no such file/dir and when i type chmod a+x logins.sh i end up back at a prompt so i try running it as logins and i get bash: logins: command not found or i try logins.sh i get same command not found im using gnome terminal assummming its a bash term.

Nylex · 12-22-2005, 11:11 AM

How about "./login.sh" (minus the quotes)? It's good that you just get the prompt after using chmod, that's what's supposed to happen if all is well.

boxerboy · 12-22-2005, 11:14 AM

Quote:

boxerboy@Linux:~$ ./logins.sh
Thu Dec 22 12:12:54 EST 2005
boxerboy :0 Dec 22 10:58
boxerboy pts/1 Dec 22 11:19 (:0.0)
boxerboy pts/0 Dec 22 12:12 (:0.0)
boxerboy@Linux:~$

see now that did it but shouldnt i beable to run it just by using logins atleast thats what the book uses

Nylex · 12-22-2005, 11:17 AM

If you mean you should be able to run it as "login.sh", without the "./" bit then it seems that you don't have "." (current directory) in your $PATH. If you actually mean "logins", then if you haven't got a file with that name you won't be able to run it as that.

boxerboy · 12-22-2005, 11:24 AM

ok so i can rename file just logins and i should beable to run it by typing "logins" at terminal? is that what you mean? cause thats my goal.

Nylex · 12-22-2005, 11:26 AM

Yep, should do as long as "." is in your $PATH. Edit: although, how come you didn't just name the file "logins" in the first place?

boxerboy · 12-22-2005, 11:33 AM

i named it logins.sh cause i used shell script in anjuta as the file type and it added the .sh at end. ok i changed it to just "logins" its in my home dir. but i dont know how to add the . to the path.

Nylex · 12-22-2005, 11:43 AM

If you have a .bash_profile file (in your home directory), there should be a line starting with "PATH=". After the last colon, just add "." (without the quotes) and save the file.

boxerboy · 12-22-2005, 11:47 AM

i dont have a .bash_profile file all i have is desktop and this file in home.

Nylex · 12-22-2005, 11:49 AM

You sure the file doesn't exist? It won't show up by just doing "ls"; you'll need "ls -a" to see it. You could change /etc/profile (but you'd need to do that as root and it would be for all users).

boxerboy · 12-22-2005, 11:55 AM

oops yeah ls didnt find it your right ls -a did find it ok now that i know i have it do i need to be saving the scripting files there? and when you said add the "." to the end of colon did you mean in the script its self? like i said im new to this

Nylex · 12-22-2005, 11:57 AM

No, in your .bash_profile, look for the line starting "PATH=" and just put a "." after the last colon.

boxerboy · 12-22-2005, 12:08 PM

Code:

# set PATH so it includes user's private bin if it exists
if [ -d ~/bin ] ; then
    PATH=~/bin:."${PATH}"
fi

that is last line in that file and i added the "." after /bin: and before the "$ is that where it should be?