Help with one bit of a nightly download script

skagnola · 07-24-2018, 02:37 PM

Hey, all

Need a little help with a script.

script usage: app-upgrade.sh
-l dir: app_home directory to be upgraded

-d dir: upgrade distribution dir

-c dir: tomcat_home root of app apache tomcat install

-u owner: the tomcat user account

The command string is being run from within the /usr/local/app/src/appdistdir dir.

Code:

./app-upgrade.sh -l /usr/local/app -d /usr/local/app/src/appdistdir -c /usr/share/tomcat -u tomcat --systemctl --noPrompt

The arg that needs to have a variable passed to it is this appdistdir bit because of a tarball that is downloaded and unpacked every night.

Code:

-d /usr/local/app/src/appdistdir

If I add something like...

Code:

upgrdir=$(ls -1t | head -1)
./app-upgrade.sh -l /usr/local/app -d upgrdir -c /usr/share/tomcat -u tomcat --systemctl --noPrompt

... I'm not confident it will work. That -d arg needs to have the absolute path passed to it. What is the best way to do that so it picks up the newly created dir after the tarball unpack?

scasey · 07-24-2018, 05:31 PM

What are you not sure of?
Does

Code:

upgrdir=$(ls -1t | head -1)

give you the correct directory?

I'm pretty sure you need $upgrdir in the execution line:

Code:

./app-upgrade.sh -l /usr/local/app -d $upgrdir -c /usr/share/tomcat -u tomcat --systemctl --noPrompt

The best way, probably, to figure out if things will work is to try them. Add echo commands of the input variables an see what you get and/or put "set -xv" at the top of app-upgrade.sh to turn on verbose debugging.

You didn't show us your script, but if you add set -xv to the top of the script, then add an exit command before the actual upgrade code, you should be able to see what's going to happen.

skagnola · 07-24-2018, 08:33 PM

Hey, scasey! Thanks for the insight.

Quote:

Originally Posted by scasey

Does

Code:

upgrdir=$(ls -1t | head -1)

give you the correct directory?

Yep, it does, as long as I am in that dir already. And the script does start there. It's just not a full, absolute path.

Quote:

Originally Posted by scasey

I'm pretty sure you need $upgrdir in the execution line:

Code:

./app-upgrade.sh -l /usr/local/app -d $upgrdir -c /usr/share/tomcat -u tomcat --systemctl --noPrompt

doh! You are correct!

Quote:

Originally Posted by scasey

You didn't show us your script, but if you add set -xv to the top of the script, then add an exit command before the actual upgrade code, you should be able to see what's going to happen.

This is my full script being run nightly. I have keefaz and syg00 to thank for getting me to some of the more complex pieces:

Code:

#!/bin/bash

cd /usr/local/app/src

#download the file
wget -t 3 http://URL/software18.3-SNAPSHOT-%7Bbuild.number%7D-softw-bin.tar.gz
RTN=$?
if [ $RTN -ne 0 ] ; then
  tail -n10 /tmp/dwnld.log | mail -s "Download Error Report" -r "root@vm" "user@contoso.com"
fi

#pull the current version in src dir
old=$(ls -1t | grep -Po -m1 '[0-9].[0-9].[0-9]\.[0-9].[0-9]')

oldMajor="${old%.*}"
oldMinor="${old#*.}"

#verify the version in download is newer than old
new=$(tar tvf software18.3-SNAPSHOT-{build.number}-softw-bin.tar.gz | grep -Po -m1 '\-\K\d+\.\d+(?=.*bin/)')

newMajor="${new%.*}"
newMinor="${new#*.}"

if (( newMajor < oldMajor || newMajor == oldMajor && newMinor < oldMinor || newMinor == oldMinor )); then
  find *.tar.gz -ctime -1 -exec rm -rf {} \; \
  && echo "Upgrade package is old. No update applied" | mail -s "Upgrade Report" -r "root@vm" "user@contoso.com"
else
  find *.tar.gz -ctime -1 -exec tar zxpf {} \; \
  && find *.tar.gz -ctime -1 -exec rm -rf {} \; \
  && cd $(ls -1t | head -1) \
  && ./manual-upgrade.sh -l /usr/local/appdir -c /usr/share/tomcat -u tomcat --systemctl --noPrompt
fi

Quote:

Originally Posted by scasey

The best way, probably, to figure out if things will work is to try them. Add echo commands of the input variables an see what you get and/or put "set -xv" at the top of app-upgrade.sh to turn on verbose debugging.

You are right. Without a clone/test VM of the same dir structure and other bits, I guess I am just concerned that the way the vendor describes use of this -d arg when calling their script it will need an absolute path. It does when doing it manually.

skagnola · 07-25-2018, 10:44 AM

Think I found the piece I was looking to do.

Since this vendor script needs the -d argument to have an absolute path, and the path changes every night due to the upgrade tarball being unpacked, I am using find to get the latest dir I'm needing to pass to that arg

Code:

upgrdir=$(find /usr/local/app/src -mtime -1 -type d -name "software18.3*")

./manual-upgrade.sh -l /usr/local/appdir -d $upgrdir -c /usr/share/tomcat -u tomcat --systemctl --noPrompt

Initially, my mind was wondering thinking I 'needed a sledgehammer to kill a fly'.

mina86 · 07-31-2018, 06:12 PM

PS. Don’t forget to quote your variables.