help me in my bash script

packets · 12-13-2009, 11:15 PM

I create a bash script with using case syntax. My bash script option must be "./script user hello". Below is the content of the script.

Quote:

user=`echo "$1" | sed "s/$/@foo.com/"`

case $1 in
*)
echo "From: $user
TEST1" > /var/log/test1

echo -n " TEST2" > /var/log/test2

;;

esac

I want to modify it and do something like this.

If I run the script ./script user (without the word "hello"), it will echo -n " TEST2" > /var/log/test2, if I run the script ./script user hello, it will return echo -n " TEST1". I'm thinking if I can do this using if syntax though I'm not sure and still checking if can do this.

Ant advise?

ghostdog74 · 12-13-2009, 11:22 PM

Code:

len=$#
user="$1@foo.com"
case "$len" in
    1) echo "TEST1";;
    2) echo -n " TEST2 #> /var/log/test2
esac

packets · 12-13-2009, 11:30 PM

thanks for the idea! I'll let you know if I still encounter some problem.

packets · 12-14-2009, 12:23 AM

Quote:

len=$#
user="$1@foo.com"
case "$len" in
1) echo "TEST1";;
2) echo -n " TEST2 #> /var/log/test2
esac

I encountered some problem here. I gonna run the script like this: ./script user hello word. On the script, 1 = user and 2 = hello, what if there are more than 2? I want to make the first 1 a variable and then any succeeding world must be equal to 2.

Here is some of my modified script

Quote:

USER=$#

case $USER in
2)
echo -n "$1"
;;
1)
echo -n "$2"

;;
esac

If I run the script ./script user hello world, I want it to echo "hello world" and not just "hello".

Can still bash do this? Any syntax you might want to suggest to fulfill this?

ghostdog74 · 12-14-2009, 12:35 AM

then you should use quotes

Code:

./script user "hello world"

otherwise, you can iterate over $@ starting from 2,

Code:

save=("$@")
user=${save[0]}
s=${save[1]}
for((i=2;i<=${#save[@]};i++))
do
    s="$s ${save[$i]}"
done
echo "user: $user, the rest:$s"

or using array indexing

Code:

save=("$@")
user=${save[0]}
s=${save[@]:1}
echo "user: $user, the rest:$s"

konsolebox · 12-19-2009, 03:27 AM

here's a suggestion:

Code:

echo "user: $1"
echo "message: ${*:2}"

note: result of ${*:2} will depend on the value of IFS. it's safe if IFS has the default value $' \t\n'

catkin · 12-19-2009, 04:18 AM

Code:

echo "user: $1:
shift
echo "message: $*"

konsolebox · 12-19-2009, 04:31 AM

Quote:

Originally Posted by catkin

Code:

echo "user: $1:
shift
echo "message: $*"

i'll agree that this is better since it's more compatible with other shells