Guessing Game

camsky209 · 11-04-2021, 09:10 PM

This is my code is it say that
./guessing_game: line 17: syntax error: unexpected end of file

system_number=87
no_of_guess=1
for (( ; ; ))
do
read -p "Guess a number between 0 and 99, inclusive:"
if [$user_number -eq $system_number ]
then
echo "your number is right!"
else
echo "your number is wrong"
if [ $user_number -ge $system_number ]
then
echo "Your guess to to high."
else
echo "Your guess to to low."
fi

Mechanikx · 11-04-2021, 09:48 PM

You didn't provide 'read' with a variable to store user input such as 'user_input'. Also you needed to close the first 'if' statement with a closing 'fi' and the 'for' loop with a closing 'done'.

I changed a couple of other things such as breaking if the user guesses the correct number, since 'system_number' never changes and '-ge' to '-gt' in the second 'if' test because once it's determined the user entered the wrong number there's no point in testing for equality.

Also you should add a restriction on user input if they can only enter numbers 0-99.

PHP Code:




#!/bin/bash

system_number=87
no_of_guess=1
for (( ; ; ))
do
read -p "Guess a number between 0 and 99, inclusive:" user_number

    if [ "$user_number" -eq "$system_number" ]
    then
        echo "your number is right!"
        break
    else
        echo "your number is wrong"

        if [ "$user_number" -gt "$system_number" ]
        then
            echo "Your guess to to high."
        else
            echo "Your guess to to low."
        fi
    fi
done

boughtonp · 11-05-2021, 07:11 AM

Surround code with [code]..[/code] blocks to post code, so formatting is not lost.

There are three syntax errors in the code presented - lack of whitespace after bracket in the first "if", lack of "fi" for the same, and lack of "done" for the loop. (The latter two would suggest you neglected to copy the whole thing, except the error says otherwise; did you write this code from scratch or copy it from somewhere?)

As per the Bash manual read without a variable name specified will default to setting REPLY. If you want to change that you must specify the name.

ShellCheck is a tool that can be used both online or offline to highlight all these (and a couple of other issues).