I'm trying to make bash, and I'm getting the following:

mkbuiltins.c:1430: argument `from' doesn't match prototype
/usr/lib/gcc-lib/i586-mandrake-linux-gnu/3.2.2/include/stdio.h:163: prototype declaration

mkbuiltins.c contains the following:

static int
rename (from, to)
char *from, *to;
{
unlink (to);
if (link (from, to) < 0)
return (-1);
unlink (from);
return (0);
}

as well as:

static int rename (char, char);

at the top. Incendently, I've tried commenting this out b/c the compiler was saying it didn't match the prototype.

And the stdio.h contains the following:

163 extern int rename (__const char *__old, __const char *__new) __THROW;

I don't really understand the syntax for this. Is there a simple answer to making this compile?

Thanks much!

this is a pretty basic error..

when you do a static definition of the function "rename", you are creating problems because the prototype from the header stdio.h says the parameters are const char* and not char *(that you have written) ..and you should also
change it to const char* for the sake of posterity...(you are not going to modify the incoming parameters..right???)...

this, while would remove the error, would still give you a warning for static defintion and extern declaration..not quite a mix....
solution : either remove the static itself..would remove all warnings

as for the __THROW__ part in the prototype in the header..
this is for use in C++, where this macro expands to throw(), for throwing exceptions


A SUGGESTION: if you are the allowed to give your own function names, then it would be better if you did not use the standard function names..it creates more confusion than easing things out

Thank you sir. I renamed the function (it's not called from anywhere else) and made the signatures match.