This gone runs but only gives a single letter as output instead of the full name. Can anyone help me out?


#include <iostream.h>
#include <iomanip.h>
#include <string.h>
#include <ctype.h>


char *GetName()
{
const int NUMEMP = 5;
const int MAXNAME = 30;
char name[30];
char i;


cout << "\nEnter a name: \n";
cin.getline (name,30);
for ( int i = 0; i < NUMEMP; i++ )

return name ;
}

int GetHrs()
{
int hrs;
cout << "\nEnter hours: \n";
cin >> hrs;
cin.ignore( 80, '\n' );

return ( hrs );

}

char GetPayCode()
{
char payCode;
cout << "\nEnter a pay code\n";
cin.get( payCode );
cin.ignore( 80, '\n' );

return ( payCode );
}

//output

void main()
{


for ( int i; i < 6; i++ )
{
cout << "\nEmployee " << i;

char name = *GetName();
char payCode = GetPayCode();
int hrs = GetHrs();
cout << setw( 30 )
<< setiosflags( ios::left )
<< setiosflags( ios::fixed )
<< "Name: " << (name)<< endl;
cout << setw( 7 )
<< setiosflags( ios::fixed )
<< setiosflags( ios::left )
<< "Pay Code: " << payCode << endl;
cout << setw( 7 )
<< setiosflags( ios::fixed )
<< setiosflags( ios::left )
<< "Hours: " << hrs << endl;

}

}

I would say use a string and use cin, getline has delimeters that may be causeing your problem, though I don't know exacly what they are.

Not having initialised the i in the
for-loop, how long does it run? :)


Cheers,
Tink

5 sets...i set i
i<6

There are a couple of problems in the bits of code I pasted above...

First, you are returning a pointer to an array that has been allocated on the function stack!! This is bad. REAL BAD! The memory that the pointer you are returning will no longer be allocated once the function returns!

Second, assuming for a moment that you aren't going to get a segmentation fault due to my first point... You are storing the result of your function (a char*) into a char, dereferncing it in the process. This will give you only a single character.

One option (not necessarily the best) would be to dynamically allocate the memory for the pointer that you are returning from your function. (Use new/malloc), then when you are done be sure to release the memory (using delete/free).

Another, would be to have your function take in a char*, allocating memory for it outside the function.

Another option is the suggestion that ooagentbender mentioned. Using a std::string instead of a char*.

I am desperately trying to get this program to work. I have to have it all turned in by 5 pm and its already 3pm. I need to create a program that asks for names, and hours. and from that data collected create a new program that displays each name the pay code which has been converted into a int {20,15, 10} based on char{A, B, C}. Then i have to calculte overtime (hours over 40 get time and a half) as well as regular hours. I've been up for 3 days without sleep, and I have very littel tworkign code to show for it. any help is appreciated.

So essentially, you are asking us to do your homework for you.

Maybe sometime in those 3 days, you could have discussed the problems you are having with your teacher. In my experience, teacher's are generally pretty understanding and will try to help you out by explaining what you are doing wrong.

I won't help you cheat, but I'll give you some sample code for one of the more appropriate ways to return a char* from a function...

That does NOT set i. That compares it.

The code that Tinkster is talking about, is this part here:

You never SET i initially, so it is likely to have a garbage value.

Instead, you should do something like so for 5 loops:

I missed that. thanks!

i decided to go with a struc instead


#include <iostream.h>
#include <iomanip.h>



int main()
{
struct PayRecord
{
char name[30]; //max char for name
char payCode[2]; //max char for code
int hrs;
};

PayRecord Employee[5];
int i;

for ( i = 0; i < 5; i++ )
{
cout << "\nEnter a name: \n" << endl;
cin >> Employee[i].name;
cout << "\nEnter hours: \n";
cin >> Employee[i].hrs;
cout << "\nEnter a pay code\n";
cin >> Employee[i].payCode;

cout << "\nName: " << Employee[i].name;
cout << "\nHours: " << Employee[i].hrs;
cout << "\nPay Code: " << Employee[i].payCode;
}
return 0;
}


it is a much more simple process

One quick comment on that code... you are defining the struct within the main() function... Usually, it's not a good idea to define a struct within the scope of a function. It will only be usable within that function, so if you later wanted to pass that struct to another function, you wouldn't be able to unless you moved the struct outside the main() function.

thank you deiussum! I know this way will give me more touble if i were to try and use it elsewhere, at this point i just want it to run
I need to turn it in, and get a grade rather than a zero. as long as it runs I'll be in the clear at this point. I'll touch it up and move things around one i get things running.