[SOLVED] bash getopts pare param

fritz001 · 02-17-2017, 02:07 PM

Hello,

I'm facing this situation and for now I'm running completely out of ideas....

Code:

while getopts :M:h:vc:w: arg; do
        case $arg in
        M)  mon="$OPTARG"
            do_checks $hostname        ;;
        v)  verbose="yes";;
        w)  w1="$OPTARG";;
        c)  c1="$OPTARG";;
        h)  hostname="$OPTARG";;
        *)   usage;;
        esac
done

Well,
1st problem
I try to exec my script as ./script -M -h _HOSTNAME_

I have no idea how to parse $hostname variable that is an argument to -h option..

fritz001 · 02-17-2017, 02:11 PM

late edit:

is working as designed if I i exec script as: ./script -h _HOSTNAME_ -M

ntubski · 02-17-2017, 02:18 PM

Like this?

Code:

while getopts :Mh:vc:w: arg; do
        case $arg in
        M)  mon="yes"
        v)  verbose="yes";;
        w)  w1="$OPTARG";;
        c)  c1="$OPTARG";;
        h)  hostname="$OPTARG";;
        *)   usage;;
        esac
done

if [ "$mon" = yes ] ; then
    do_checks $hostname
fi

fritz001 · 02-17-2017, 02:25 PM

Quote:

Originally Posted by ntubski

Like this?

Code:

while getopts :Mh:vc:w: arg; do
        case $arg in
        M)  mon="yes"
        v)  verbose="yes";;
        w)  w1="$OPTARG";;
        c)  c1="$OPTARG";;
        h)  hostname="$OPTARG";;
        *)   usage;;
        esac
done

if [ "$mon" = yes ] ; then
    do_checks $hostname
fi

you just saved my day !!!

and here is 2nd issue

if parameter -M is used => to require as mandatory also params -w -c

szboardstretcher · 02-17-2017, 02:26 PM

Because the original order says 'do_checks $hostname', define $hostname.

So $hostname isn't defined yet. With -h first, you define the $hostname, then run -M using it.

grail · 02-17-2017, 02:32 PM

Better to ask your questions all at once as dribs and drabs will start to frustrate some people

As shown by ntubski, you already have an 'if' setup that says -M was chosen, so within that 'if' you can also test if w1 and c1 were set and if not, display a message to advise these are required
when using -M OR if the values are pre-known defaults you could set them if not already set to new values

fritz001 · 02-17-2017, 02:43 PM

Quote:

Originally Posted by grail

Better to ask your questions all at once as dribs and drabs will start to frustrate some people

As shown by ntubski, you already have an 'if' setup that says -M was chosen, so within that 'if' you can also test if w1 and c1 were set and if not, display a message to advise these are required
when using -M OR if the values are pre-known defaults you could set them if not already set to new values

yep, got the idea now