Ambiguos redirect in a shell script

adumith · 03-25-2013, 02:49 PM

Hello everyone;

I have made this script that run by cron job, so this work great at development enviroment but when I put this in prodution enviroment, this doesn´t work and give me back the error: ambigous redirect

I wonder if some body are able to help me with this.

Code:

#!/bin/sh
exec >/tmp/cron.debug.$$ 2>&1
cd /root/
token=`php token.php`
p2="&c="$token
urlprefix='http://www.midominio.com/dir1/dir2/ScriptPHP.php?secc='
urls=("$urlprefix"{10$p2,13$p2,19$p2,20$p2,23$p2,24$p2,26$p2,27$p2,29$p2,32$p2,34$p2,37$p2,83$p2})
if /usr/bin/wget "${urls[@]}"; then
    echo "Exitoso"
    exit 0
else
    echo "Fallido"
    exit 1
fi
exit

pan64 · 03-26-2013, 02:16 AM

I think we do not know what is your development environment and production environment (and what is the difference). You would need to describe the differences. You can add set -x as the second line and see the result. How is this script started (in both cases)?

unSpawn · 03-26-2013, 02:58 AM

...additionally there's no need to exec and redirect stdout / stderr to a log file (errors will be in the mail anyway), there's no reason (or evidence) this cron job should run as root (instead of using an unprivileged user account), mixing full and relative paths should be avoided (just use full paths or extend the $PATH), also see proper quoting, mixing backticks and $() should be avoided (readability), mixing single and double quotes should be avoided (unless you know why you don't want the shell to eval a value or escape reserved chars instead), plus you're not using the command output but just its exist status (so 'curl -s' or wget -q' should do).