Humbly need help with if statements in an array

finalturismo · 02-06-2023, 03:20 AM

So iam having issues with the following statements and i cant see to figure out whats going on but here is the message .
vscode states the following statement, expressions don't expand in single quotes, use double quotes for that.

the problem is rip grep is having a bit of an issue processing the following statements and cant compare the variables.
cronjobs4servers=(
@reboot vmtouch -d -L /etc
'0 * * * * if [[ $(rc-service nfs-kernel-server status | rg -i -o "running") != "running" ]]; then rc-service nfs-kernel-server start; fi'
'0 * * * * if [[ $(rc-service smbd status | rg -i -o "running") != "running" ]]; then rc-service smbd start; fi'
'0 * * * * if [[ $(rc-service autofs status | rg -i -o "running") != "running" ]]; then rc-service autofs start; fi'
'0 * * * * if [[ $(rc-service nginx status | rg -i -o "running") != "running" ]]; then rc-service nginx start; fi'
'0 * * * * if [[ $(rc-service mariadb status | rg -i -o "running") != "running" ]]; then rc-service mariadb start; fi'
'0 * * * * if [[ $(rc-service rpcbind status | rg -i -o "running") != "running" ]]; then rc-service rpcbind start; fi'
'0 * * * * if [[ $(rc-service docker status | rg -i -o "running") != "running" ]]; then rc-service docker start; fi'
'0 * * * * if [[ $(rc-service networking status | rg -i -o "running") != "running" ]]; then rc-service networking start; fi'
'0 * * * * if [[ $(rc-service php-fpm status | rg -i -o "running") != "running" ]]; then rc-service php-fpm start; fi'
'0 * * * * if [[ $(rc-service php7.4-fpm status | rg -i -o "running") != "running" ]]; then rc-service php7.4-fpm start; fi'
'0 * * * * if [[ $(rc-service php8.0-fpm status | rg -i -o "running") != "running" ]]; then rc-service php8.0-fpm start; fi'
'0 * * * * if [[ $(rc-service php8.1-fpm status | rg -i -o "running") != "running" ]]; then rc-service php8.1-fpm start; fi'
'0 * * * * if [[ $(rc-service php8.2-fpm status | rg -i -o "running") != "running" ]]; then rc-service php8.2-fpm start; fi'
'0 * * * * if [[ $(rc-service nginx status | rg -i -o "running") != "running" ]]; then rc-service nginx start; fi'
'0 * * * * if [[ $(rc-service mariadb status | rg -i -o "running") != "running" ]]; then rc-service mariadb start; fi'
)

if [[ ${systemtype[n]} = server ]]; then
for ((cjs = 0; cjs < ${#cronjobs4servers[@]}; cjs++)); do
if [[ $(ssh -M root@fixapc.net -p "${srvmonsshport[$n]}" cat /var/spool/cron/crontabs/root | rg -o -e "${cronjobs4servers[cjs]}") != "${cronjobs4servers[cjs]}" ]]; then
echo -e "${cronjobs4servers[cjs]}" >>/var/spool/cron/crontabs/root
fi
done
fi

pan64 · 02-06-2023, 04:38 AM

I don't really understand why do you use rg, but would be better to use it with full path.

jmgibson1981 · 02-06-2023, 06:05 AM

Also you might be better off doing a script with a variable. then you only need to add the service type

Code:

#!/bin/sh

[ $(rc-service "$1" status | rg -i -o "running") == "running" ] || rc-service "$1" start

Then just call it like so from cron

0 * * * * $script mariadb
0 * * * * $script smbd

and so forth. Single changes to make instead of each line if it ever needed to be mucked about with.

michaelk · 02-06-2023, 10:12 AM

Code:

0 * * * * if [[ $(rc-service smbd status | rg -i -o "running") != "running" ]]; then rc-service smbd start; fi

I don't know what cron version you are running but typically have a fixed environment that uses /bin/sh. It isn't a rg problem but a "cron" problem since [[ ]] isn't defined in /bin/sh.

pan64 · 02-06-2023, 10:55 AM

Quote:

Originally Posted by michaelk

Code:

0 * * * * if [[ $(rc-service smbd status | rg -i -o "running") != "running" ]]; then rc-service smbd start; fi

I don't know what cron version you are running but typically have a fixed environment that uses /bin/sh. It isn't a rg problem but a "cron" problem since [[ ]] isn't defined in /bin/sh.

yes, you are right. But actually

Code:

if rc-service smbd status | grep -q running >/dev/null; then

or something similar is enough. And probably

Code:

rc-service smbd status | grep -q running || rc-service smbd start

is ok too.

michaelk · 02-06-2023, 12:04 PM

True, In addition on my devuan openrc system rc-service status outputs "<service> not running ... failed". Not sure if it is different on other openrc distributions but that would make the results true regardless if the service was running or not. The OP might have to change the grep search criteria.

MadeInGermany · 02-08-2023, 11:22 AM

Quotes missing here?:

Code:

cronjobs4servers=(
'@reboot vmtouch -d -L /etc'

crontab uses /bin/sh and [[ ]] is not defined in sh. (Will work only if /bin/sh is a link to bash.) Use [ ] instead, and its arguments should be in quotes (not strictly needed here).

Code:

'0 * * * * if [ "$(rc-service mariadb status | rg -i -o "running")" != "running" ]; then rc-service mariadb start; fi'
)

Does rc-service provide an exit status? Then it would shorten to

Code:

'0 * * * * rc-service mariadb status >/dev/null 2>&1 || rc-service mariadb start'

Only the red part is running on the remote machine:

Code:

if [[ $(ssh -M root@fixapc.net -p "${srvmonsshport[$n]}" cat /var/spool/cron/crontabs/root | rg -o -e "${cronjobs4servers[cjs]}") != "${cronjobs4servers[cjs]}" ]]; then
echo -e "${cronjobs4servers[cjs]}" >>/var/spool/cron/crontabs/root
fi

If you want to run more on the remote machine then quoting becomes a bit tricky, because it is processed=dequoted locally and then remotely.

Code:

ssh -M root@fixapc.net -p "${srvmonsshport[$n]}" "/bin/bash -s '${cronjobs4servers[cjs]}'" << "_EOT"
  if ! fgrep -qxe "$1" < /var/spool/cron/crontabs/root
  then
    echo "$1" >>/var/spool/cron/crontabs/root
  fi
_EOT

I use fgrep (grep -F) for plain string match, so it will treat characters like * [ ] as literals. -x full line match, -q supress output (act on its exit status).
A quoted here document is protected on the local host. And passed via stdin through ssh to the remote /bin/bash. Because variables are not substituted, they are passed via arguments -> positional parameters