Hello,
I am trying to read binary file in c but my code is not working properly.
I am not getting the same output as that in file. you can view my code below.


int i=0;
void main()
{
FILE *fp;
int* buffer;
unsigned long fileLen;

int numread=0;
// int numread=0;
fp=fopen("bindata1.txt","rb"); //reading transmitted baseband data from a file
if(fp==NULL)
{
puts("cannot open file");
exit(0);
}

else
{
fseek(fp, 1, SEEK_END);
fileLen=ftell(fp);
fseek(fp, 1, SEEK_SET);

buffer=(int*) malloc(fileLen);
numread=fread(buffer,1,fileLen,fp);//1 indicate 1 byte i.e. 8 bits of data.
for(i=0;i<=2;i++)
{
printf("%b",&buffer[i]);

// printf("%d\n",numread);
}

fclose(fp);
}
getch();
}
Kindly tell me my mistake.
Thanks

First Of all, why is main void? How will you communicate exit status?

On modern systems, binary and "normal" reading are the same. The "b" has no effect.

I'm guessing your off by one? the stream starts at 0 and you started at 1
fseek(fp, 1, SEEK_SET);
should be
fseek(fp, 0, SEEK_SET);

As DJ Shaji said, main should be declared as

Since you exit when the fp is NULL, there is no need for the else clause.
malloc returns a void pointer. In C there is a implicit conversion from
void to any pointer, so if the program will be compiled using a C
compiler (and not a C++ compiler), the cast is not needed.
Also, you should always check if malloc has actually allocated any
memory. Your file may be large or it can fail for any other reason.

I don't understand what do you want to print here, but anyway "%b" is
not in the standard. I think that Visual studio implements it, but
your program won't be portable.

I hope i helped

Thanks sir, Now its working .