Hi,

I have a script with a sed statement included. When I execute it manually it produces the normal output, but doesnt happen when it is executed by cron. It shows the below output;

Your "cron" job on 141-1
/export/home/sigvalue/check_bind.sh > /dev/null

produced the following output:

sed: command garbled: 2519, 3708 p

and the code is like this;

sed -n "$STSIZE,$CUR_SIZE p" \
$LOGDIR/current.log \
> $TEMPDIR/bind.error.diff

And are all those variables visible to cron/inside the script? We're
not clairvoyant, you see ... :}

Hello elthox

Chances are some of the variables you are relying on are not set in the environment that the script runs in as a cron job.

You can check by puttingin the script.

If what you need isn't there because the login process has not been run (it isn't, by cron) you should be able to fix it by putting this on the first line of your script:(that's a letter l)

Best

Charles

Thanks for your reply.

I tried adding -l option but it was not recognised as below;

Your "cron" job on 141-1
/export/home/sigvalue/check_bind.sh > /dev/null

produced the following output:

/bin/bash: -l: unrecognized option
Usage: /bin/bash [GNU long option] [option] ...
/bin/bash [GNU long option] [option] script-file ...
GNU long options:
--debug
--dump-po-strings
--dump-strings
--help
--init-file
--login
--noediting
--noprofile
--norc
--posix
--rcfile
--restricted
--verbose
--version
--wordexp
Shell options:
-irsD or -c command (invocation only)
-abefhkmnptuvxBCHP or -o option


I`m also pasting my script where vaiables take place.


#!/bin/bash -l


TEMPDIR=/export/home/sigvalue/
LOGDIR=/export/home/sigvalue/logs/SMPP_SERVER-A/
CUR_SIZE=`cat $LOGDIR/current.log|wc -l`
PREV_SIZE=`cat $TEMPDIR/current.size`

if [ $CUR_SIZE -eq $PREV_SIZE ]
then
echo "Nothing to do..." > $TEMPDIR/bind.error.diff
exit
fi

if [ $CUR_SIZE -gt $PREV_SIZE ]
then
let STSIZE=$PREV_SIZE+1

sed -n "$STSIZE,$CUR_SIZE p" \
$LOGDIR/current.log \
> $TEMPDIR/bind.error.diff
cat $TEMPDIR/bind.error.diff|egrep "UNBIND|failed|Client Is not connected" > $TEMPDIR/error
if [ -s $TEMPDIR/error ]
then
wget --post-data="serverName=SMPP-A&msgBody=`cat $TEMPDIR/error`" http://10.1.21.236:8585/pns.asmx/SendEmail
rm $TEMPDIR/error
fi
fi
echo $CUR_SIZE > $TEMPDIR/current.size


Thanks guys

Hello elthox

Try changing the first line of the script from #!/bin/bash -l to #!/bin/bash --login

If that doesn't help, let's try and get some more information. Just before the problem sed command add these lines$$ is the process ID; it will give the two ~/trash.* files different names. After running the script manually and by cron, use diff to compare the two ~/trash.* files, including any difference in the sed command on the last line.

You might also try changingto It shouldn't make any difference but simplifying can help identify the unexpected.

Best

Charles

Thankyou guys,

It was much simpler, just adding . $HOME/.profile at the beginning

Now it works


Thanks

You might want to check the line "CUR_SIZE=`cat $LOGDIR/current.log|wc -l`". It might be more proper you used:
`wc -l networking-concepts-HOWTO.letter.ps | cut -f1 -d' '` instead to cut out the filename and leave just the integer.

If the script you tested doesn't run, the $HOME variable might not be set.

Use delimiters in the sed command:
As you probably know, the sed command prints a range of lines between $STSIZE and $CUR_SIZE.

Make sure that the first time you run the script, that the contents of '$TMPDIR/current.size' makes sense.

How do you deal with log rotation on the system? The contents of the log will change and the range values won't be valid.

Hi,


Regarding log rotation...is it logical to make an if control such as

previoussize=1000
currentsize=3 (after the rotation new current.log is being written)

if [ $previoussize -gt $currentsize ]
then
...do nothing
fi

Is it logical or it may be another way?

Thanks

Glad you got it working

If you are going to develop and test scripts while logged on (the alternative is difficult!) it's safer to use #!/bin/bash --login because that sets up, as far as practicable, an identical environment. Several files are used to set up your environment when you log on. In this case ~/.profile was the significant one; it may not always be.