scripting: how to cp a list of files which starts with - or space without

simransab · 10-14-2009, 03:01 AM

I have a list of files in a directory which starts with - or have space.
I need to copy them back without the space or -?
Anyone can help me, urgently?

linux1[sim]% ls
-01_SUMMARY_REPORT_ETS030531_10142009.txt -842150451_ETS171528_10012009.log

linux1[sim]% cp ./-* ./*
cp: copying multiple files, but last argument `./-842150451_ETS171528_10012009.log' is not a directory

catkin · 10-14-2009, 03:32 AM

Try something like this (not tested)

Code:

ls -1 | while read old_fn
do
    new_fn="${old_fn//-/}"
    new_fn="${new_fn// /}"
    echo "DEBUG: old_fn: '$old_fn'"
    echo "DEBUG: new_fn: '$new_fn'"
done

EDIT: corrected new_fn="${old_fn// /}" to new_fn="${new_fn// /}"

lutusp · 10-14-2009, 03:35 AM

Quote:

Originally Posted by simransab

I have a list of files in a directory which starts with - or have space.
I need to copy them back without the space or -?
Anyone can help me, urgently?

linux1[sim]% ls
-01_SUMMARY_REPORT_ETS030531_10142009.txt -842150451_ETS171528_10012009.log

linux1[sim]% cp ./-* ./*
cp: copying multiple files, but last argument `./-842150451_ETS171528_10012009.log' is not a directory

So the file names begin with either a space or a dash, yes? And you want to strip the space or the dash, yes?

Code:

find /path -type f | while read from
do
   to="$from"
   to=${to/-}
   to=${to/ }
   echo "from: \"$from\" to: \"$to\""
   # mv "$from" "$to"
done

Don't uncomment the commented line until you are satisfied that the script does what you want.

rizhun · 10-14-2009, 03:35 AM

Hi simransab,

Try this:

Code:

$ cd /to/directory/with/files
$ ls -1 | while read filename
> do
>    newfilename=$(echo ${filename} | sed -e 's/ /_/g' -e 's/^-//')
>    mv -- "${filename}" "${newfilename}"
> done

I did a quick test and it worked for me in Bash.

Good luck

simransab · 10-14-2009, 07:31 PM

hi lutusp and rizhun,

thanks i tried but there are few syntax error. Can you explain the syntax? Im new to scripting, i dont understand esp at "sed" and "find /path" function.

Thanks

rizhun · 10-15-2009, 01:42 AM

Syntax errors?
Did you exclude the $'s and >'s? They are only there for clarity, your shell should create them for you.

Code:

$ ls -1 | while read filename                                        # -> ls the directory returning only filenames
> do                                                                 # -> start the loop
>    newfilename=$(echo ${filename} | sed -e 's/ /_/g' -e 's/^-//')  # -> use sed to substitute spaces for under-scores and any dash at the beginning of the file is removed
>    mv -- "${filename}" "${newfilename}"                            # -> rename the file
> done                                                               # -> end the loop

I tested this on Linux & Bash and it worked for me.

The 'sed' part of this command has 2 steps:

's/ /_/g' --> the 's' means it's a substitution. the / /_/ means substitute a space for an under-score. the 'g' means globally ie. multiple times on one filename if required.

's/^-//' --> another 's' for substitution. the '^' matches the very beginning of the line, so '/^-//' means substitute a '-' a the beginning of the line for nothing ('//') ie. remove it.

i92guboj · 10-15-2009, 01:55 AM

Quote:

Originally Posted by catkin

Try something like this (not tested)

Code:

ls -1 | while read old_fn
do
    new_fn="${old_fn//-/}"
    new_fn="${new_fn// /}"
    echo "DEBUG: old_fn: '$old_fn'"
    echo "DEBUG: new_fn: '$new_fn'"
done

EDIT: corrected new_fn="${old_fn// /}" to new_fn="${new_fn// /}"

Why you shouldn't parse the output of ls

Either use find (preferably with -print0) or bash builtins.

rizhun · 10-15-2009, 02:36 AM

Quote:

Originally Posted by i92guboj

Why you shouldn't parse the output of ls

Either use find (preferably with -print0) or bash builtins.

Ok...

Code:

$ cd /to/directory/with/files
$ find . -type f | while read filename
> do
>    newfilename=$(echo ${filename} | sed -e 's/ /_/g' -e 's/^-//')
>    mv -- "${filename}" "${newfilename}"
> done

Be careful though, this will traverse down the file-system structure.

lutusp · 10-15-2009, 04:12 AM

Quote:

Originally Posted by simransab

hi lutusp and rizhun,

thanks i tried but there are few syntax error. Can you explain the syntax? Im new to scripting, i dont understand esp at "sed" and "find /path" function.

Thanks

If a drill sergeant said "I ... state your name ...", would you say your name, or would you say "state your name"? It's the same here -- replace "/path" with the path you personally want to search.

Quote:

Originally Posted by simransab

thanks i tried but there are few syntax error.

Could you possibly be more specific? Imagine being aboard a gigantic airliner and the stewardess says, "Don't worry about that burning wing, folks, the pilot has called the control tower and announced that there are a few syntax errors." Would you worry about your future?