Prompt not hard returning after PS1 variable change?

SlowCoder · 04-12-2007, 08:31 PM

I created this script for my .bashrc file, to reshape my prompt:

Code:

# User specific aliases and functions

#Colors:
#Black       0;30     Dark Gray     1;30
#Blue        0;34     Light Blue    1;34
#Green       0;32     Light Green   1;32
#Cyan        0;36     Light Cyan    1;36
#Red         0;31     Light Red     1;31
#Purple      0;35     Light Purple  1;35
#Brown       0;33     Yellow        1;33
#Light Gray  0;37     White         1;37

PROMPTCOLOR='\e[1;37m'
COMMANDCOLOR='\e[0;37m'
USERNAMECOLOR='\e[1;32m'
PS1="${USERNAMECOLOR}\u${PROMPTCOLOR} [\w] >${COMMANDCOLOR} "

It works well, but I apparently have a side-effect, in that if I type a command longer than the width of the screen, it seems to fail to do a hard return, overwriting the current line. What did I mess up?

P.S. I really like this script. It works well for me. I set up my root script so it shows in red, which reminds me of my current user state.

forrestt · 04-12-2007, 09:12 PM

Just to be sure we are seeing an anomaly with your script, do you see the same side-effect if you don't run the prompt change in your .bashrc?

SlowCoder · 04-13-2007, 07:51 PM

Yes, it is. Here is a display with the default PS1:

Code:

[geoff@localhost ~]$ lfkjsdlfkjsdlfksdjflsdkfjsdlfkjsdf lksdjf lsdkjf sdlkfj sdlkfj sldkfj sdlkfj sdlkjf

And here is the display with my modified PS1:

Code:

 kdff [~] > sldkfj sdlkfj sdlkfjsdflksjd flskdjf sldklsdkfj

Thank you for your time.

SlowCoder · 04-20-2007, 07:12 AM

bump ...
Anyone?

SlowCoder · 05-01-2007, 12:06 PM

bump ... again ... hoping for some answer ...

I've narrowed it down to the color variables, and not the PS1 prompt directly. I removed all references to the color variables from the PS1 variable, and the problem went away. I tried each color variable in turn, and the problem returns. I also tried adding the ;00 (null) to the prompt, but that doesn't do anything helpful.

I really like my prompt configuration, but I would like to get rid of this one side-effect.

SlowCoder · 05-01-2007, 09:16 PM

Ok, I'll admit it, I feel good. I figured it out ... all by myself, and without y'all's help!

I figured out that bash determines the text wrap based on the length of the PS1 variable. So I had to add \[ and \] to nonvisible/special codes, which included the color codes.

This is my code so far, and I plan to extend it further:

Code:

#Color Codes:
#Black       0;30     Dark Gray     1;30
#Red         0;31     Light Red     1;31
#Green       0;32     Light Green   1;32
#Brown       0;33     Yellow        1;33
#Blue        0;34     Light Blue    1;34
#Purple      0;35     Light Purple  1;35
#Cyan        0;36     Light Cyan    1;36
#Light Gray  0;37     White         1;37

PROMPTCOLOR='\[\e[1;37m\]'
COMMANDCOLOR='\[\e[0;37m\]'
ROOTCOLOR='\[\e[1;31m\]'
NORMALUSERCOLOR='\[\e[1;32m\]'
HOSTNAMECOLOR='\[\e[1;35m\]'
DIRECTORYCOLOR='\[\e[1;33m\]'

### username ###
if [ 'whoami' = 'root' ]
        then USERCOLOR=$ROOTCOLOR
        else USERCOLOR=$NORMALUSERCOLOR
fi
PS1=$USERCOLOR"\u"

### hostname ###
PS1=$PS1$PROMPTCOLOR@
PS1=$PS1$HOSTNAMECOLOR$(hostname -s)

### working directory ###
PS1=$PS1$PROMPTCOLOR" ["
PS1=$PS1$DIRECTORYCOLOR"\w"
PS1=$PS1$PROMPTCOLOR"]"

### prompt end marker ###
PS1=$PS1$USERCOLOR" \$ "

### command color ###
PS1=$PS1$COMMANDCOLOR

I would be happy to receive positive criticism on my script, whether to tell me how to make it better, or to tell me how much you like it.