[SOLVED] "idle_balance()" is properly called in schedule()?

jrkwon · 02-09-2011, 07:42 AM

I may have some confusion but the below code should be changed to using "likely" macro?

schedule()
{
...
if(unlikely(!rq->nr_running))
idle_balance(cpu, rq);
...
}

In my understanding, the idle_balance() seems have to be called when there is no active tasks (nr_running == 0).

Any comment would be highly appreciated.

Thanks.

jrkwon · 02-09-2011, 09:12 PM

My big mistake on "unlikely" macro...
The original sentence is absolutely correct.