[SOLVED] for in do files with spaces

scott_audio · 08-18-2009, 01:35 AM

goal: directory of .ogg files, convert to .mp3

I couldn't figure out how to loop through the files with spaces, so I replaced with _ and my sox isn't compiled with encode mp3, so i convert to wav then to mp3.. is there a better way to go about this? what i have works, but its not standard at best (as if i know what standard is), and at worst... well i'm daft

For the sake of learning something and seeing a good example of a better way to do this, can someone improve on this? thanks I'm converting public domain audio books to play on my archos, if that matters

Code:

find . -name '* *' | while read file;
do
target=`echo "$file" | sed 's/ /_/g'`;
mv "$file" "$target";
sox $target $target.wav
rm $target
lame $target.wav $target.mp3
rm $target.wav
done;

scott_audio · 08-18-2009, 01:39 AM

example of file listing:

Chapter 01 Call of the Wild.ogg
Chapter 02 Call of the Wild.ogg

and so on...

colucix · 08-18-2009, 01:53 AM

First, you have to use double quotes to embed the variable names, otherwise every command interpret spaces as field separator. Second, you can use process substitution to pass the list of files as standard input to the while loop:

Code:

while read file
do
  sox "$file" "${file/ogg/wav}"
  lame "${file/ogg/wav}" "${file/ogg/mp3}"
done < <(find . -name \*.ogg)

This uses parameter substitution to manage the file extensions.

scott_audio · 08-18-2009, 08:43 AM

ahh ok, I see now - you've helped clear up a lot of my misunderstanding - thank you