Create a script that mounts a share, checks a file if it has not been modified in 2 or 1 days, and then unmounts it?

riahc3 · 05-19-2022, 05:27 AM

<Code removed>

I believe the issue is that "mount" isnt working. Running this as root works so the script isnt the issue. I know the username that runs the script.

pan64 · 05-19-2022, 06:07 AM

please use code tags that makes your script more readable
also would be nice to add some error handling to know which command was executed successfully.
And also there should be some error messages.

riahc3 · 05-19-2022, 06:14 AM

Quote:

Originally Posted by pan64

please use code tags that makes your script more readable
also would be nice to add some error handling to know which command was executed successfully.
And also there should be some error messages.

25 lines of code....

Yeah that would be nice but I dont know how to do it.

To my surprise, I dont see any error message. It just gets to the last line

rtmistler · 05-19-2022, 06:15 AM

Quote:

Originally Posted by riahc3

Code:

mount -t cifs //192.168.3.222/SHARENAME/FOLDER /mnt/FOLDER -o ro,username=USER,vers=1.0,password=PASS,nodev,uid=backup,file_mode=0444,dir_mode=0444

I believe the issue is that "mount" isnt working. Running this as root works so the script isnt the issue. I know the username that runs the script.

If you issue this mount command manually from the command line, does it work successfully?

Overall, what you can do are:

Add "set -vx" after your shebang line to enable debug output and that will give you additional information when you run the script.
You also can assign a variable to the output result of mount and echo that variable to ensure that mount succeeded.
Further as a script enhancement, you can either error out of the script with a log or continue, after checking the result of mount.

riahc3 · 05-19-2022, 06:18 AM

Quote:

Originally Posted by rtmistler

If you issue this mount command manually from the command line, does it work successfully?

Overall, what you can do are:

Add "set -vx" after your shebang line to enable debug output and that will give you additional information when you run the script.
You also can assign a variable to the output result of mount and echo that variable to ensure that mount succeeded.
Further as a script enhancement, you can either error out of the script with a log or continue, after checking the result of mount.

Yeah, thru CLI it works.

set -vx doesnt show my anything

How do I store the output result of mount and then echo that variable?

Would love to error out if mount doesnt work

riahc3 · 05-19-2022, 06:20 AM

It just gives me the error of must be superuser to mount (what I suspected)

rtmistler · 05-19-2022, 06:21 AM

Quote:

Originally Posted by riahc3

25 lines of code....

Yeah that would be nice but I dont know how to do it.

To my surprise, I dont see any error message. It just gets to the last line

I get it. Many is the time I wrote a quick 10 line script and by the time I was done it was larger.

Hopefully the diagnostic methods I've cited can get you further

I really do feel it would be worth adding a check to confirm mount succeeded:

Code:

VAR=mount ...
if [ $VAR .eq 0 ]; then (it succeeded)

rtmistler · 05-19-2022, 06:22 AM

Quote:

Originally Posted by riahc3

It just gives me the error of must be superuser to mount (what I suspected)

Then the script is not user root as you felt it should be.

Suggest using the sudo command modifier for the mount command.

riahc3 · 05-19-2022, 06:25 AM

Quote:

Originally Posted by rtmistler

Then the script is not user root as you felt it should be.

Quote:

Originally Posted by riahc3

Running this as root works so the script isnt the issue. I know the username that runs the script.

Quote:

Originally Posted by rtmistler

Suggest using the sudo command modifier for the mount command.

The user that runs the script isnt a superuser (cant be either for obvious security reasons)

pan64 · 05-19-2022, 06:27 AM

regarding code tags: I posted the link where is it explained. Would be nice to check that link
You need to learn a lot about linux and shell to understand how does it work.
For example set -xv itself will just switch on debugging output, but will not tell you anything about the error. Other commands will have more verbose output.
By default every system command will print an error message (including mount), so when you execute your script you have to see that error message.
There are ways to suppress error messages and handle errors, we don't know your environment and other settings, so we don't know how did you invoke this script.

riahc3 · 05-19-2022, 06:29 AM

<Code removed>

Updated code

riahc3 · 05-19-2022, 06:31 AM

Quote:

Originally Posted by pan64

when you execute your script you have to see that error message.

mount: /mnt/folder: must be superuser to use mount.

pan64 · 05-19-2022, 06:39 AM

Code:

res=mount -t cifs //192.168.3.222/SHARENAME/FOLDER /mnt/FOLDER -o ro,username=USER,vers=1.0,password=PASS,nodev,uid=backup,file_mode=0444,dir_mode=0444
if [ $res -ne 0 ]; then

This is wrong.
This should be:

Code:

mount -t cifs //192.168.3.222/SHARENAME/FOLDER /mnt/FOLDER -o ro,username=USER,vers=1.0,password=PASS,nodev,uid=backup,file_mode=0444,dir_mode=0444
res=$?
if [ $res -ne 0 ]; then

add sudo before mount, like this:

Code:

sudo mount -t cifs ....
res=$?

if you need

riahc3 · 05-19-2022, 06:42 AM

Quote:

Originally Posted by pan64

This is wrong.

Quote:

Originally Posted by rtmistler

I really do feel it would be worth adding a check to confirm mount succeeded:

Code:

VAR=mount ...
if [ $VAR .eq 0 ]; then (it succeeded)

Wasnt me.

Sure Ill add a sudo before the commmand, one min.

riahc3 · 05-19-2022, 06:44 AM

"UNKNOWN: Mount did not work"

😂 Obviously, Im not surprised.