Conditional (IF) test in bash sh script

Critcho · 09-30-2008, 03:53 PM

I have devices that I have to FTP to and copy log files from. The log files have 3 generations, that typically roll over every few days. i.e. if I pulled the files down yesterday, I dont want all 3 generations; if it's been a while, I do.

So I have made a script, I expected to be able to pass it a parameter to decide which files to bring down, but it isn't working.

e.g. ". GetLogFiles.sh" will get just the latest generation, ". GetLogFiles.sh a" will get all.

My script looks something like

Code:

#!/bin/sh

HOST='1.2.3.4'
USER='user1'
PASS='password'
FTP='/usr/bin/ftp'
Today="`date +%y%m%d`"

        CMD1='get //var//log//messages SiteName_'$Today'.messages.log'
        CMD2='get //var//log//messages.0 SiteName_'$Today'.messages.0.log'
        CMD3='get //var//log//messages.1 SiteName_'$Today'.messages.1.log'

        if [ "$1"!="a" ]; then
                echo "Only copying messages, not messages.0 or messages.1"
                CMD2=''
                CMD3=''
        fi

$FTP -n -v $HOST << END_S

quote USER $USER
quote PASS $PASS

hash

$CMD1
$CMD2
$CMD3

END_S

I tired a few variants of

Code:

    if [ "$1"!="a" ]; then
    if [ $1!="a" ]; then
    if ![ $1=="a" ]; then

etc to no avail. At the moment it grabs all files.

Any clues?
Thanks!
Critcho.

ilikejam · 09-30-2008, 03:57 PM

Hi.

Try:

if [ "$1" -ne "a" ]

Dave

PTrenholme · 09-30-2008, 04:46 PM

Or, since $1 may be null, if [ x$1 -ne xa ], although quoting (as ilikejam suggested) should work quite well.

Kenhelm · 09-30-2008, 05:22 PM

-ne is a numeric test but $1 seems to be a string variable.
The string test != needs a space on both sides of it. Try:-

Code:

if [ "$1" != "a" ]; then

Critcho · 09-30-2008, 05:28 PM

Quote:

Originally Posted by Kenhelm

The string test != needs a space on both sides of it. Try:-

Code:

if [ "$1" != "a" ]; then

Cool, that did it! Knew it was something painfully simple....

THANKS!!!!

ilikejam · 09-30-2008, 05:36 PM

Quote:

Originally Posted by Kenhelm

-ne is a numeric test

Oh yeah. So it is. Back to school for me I think.

chrism01 · 10-01-2008, 12:20 AM

an alternate to this

CMD1='get //var//log//messages SiteName_'$Today'.messages.log'

is

CMD1="get //var//log//messages SiteName_${Today}.messages.log"