LinuxQuestions.org
Latest LQ Deal: Complete CCNA, CCNP & Red Hat Certification Training Bundle
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Newbie
User Name
Password
Linux - Newbie This Linux forum is for members that are new to Linux.
Just starting out and have a question? If it is not in the man pages or the how-to's this is the place!

Notices


Reply
  Search this Thread
Old 05-01-2011, 02:46 PM   #1
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Rep: Reputation: 0
Bash script - two for loops with array problem...


Hello!

I am trying to execute a .c program of mine through bash...

Problem is it takes two arguments (files) and am trying to use "for" loops to do it. I use the for loops to take the files (same number in both directories) and put them into arrays. I use the command "ls -1" in the "for loop" so they are sorted in such a way that they are in the same time and date order upon when the program is executed.

Here is the code:
Code:
for a in `ls -1 /analyses/data1/*_prt.txt`;
do  echo $a;
done

for sfc in `ls -1 /analyses/data2/*_ht.txt`;
do 
  ./plot_data $a $b >> log_file.log;
done
HOWEVER, $a in this case does not change with the loop. Thus, the program doesn't work.

So, I then tried:

Code:
for a in `ls -1 /analyses/data1/*_prt.txt`;
for sfc in `ls -1 /analyses/data2/*_ht.txt`;
do 
  ./plot_data $a $b >> log_file.log;
done
But that produces the error: syntax error near unexpected token `for'. As a "do" statement must come after the for loop call.

Any ideas how to do this? Just need to run the program with the two arrays and have them both advance together.
 
Old 05-01-2011, 02:57 PM   #2
Reuti
Senior Member
 
Registered: Dec 2004
Location: Marburg, Germany
Distribution: openSUSE 13.1
Posts: 1,327

Rep: Reputation: 254Reputation: 254Reputation: 254
Modify the second case so that also the outer loop uses a do and done.

BTW: `ls ...` isn’t necessary. A plain /analyses/data1/*_prt.txt will also do it.

Last edited by Reuti; 05-01-2011 at 02:58 PM. Reason: Added ls replacement
 
Old 05-01-2011, 03:01 PM   #3
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Such as:

Code:
for a in `ls -1 /analyses/data1/*_prt.txt`;
do
for sfc in `ls -1 /analyses/data2/*_ht.txt`;
do 
  ./plot_data $a $b >> log_file.log;
done
done

Only problem I worry about is that won't it increase the outer loop and then increase the inner loop unevenly? I mean it would execute it like:
./plot_data $a[0] $b[0] >> log_file.log;
./plot_data $a[0] $b[1] >> log_file.log;
./plot_data $a[0] $b[2] >> log_file.log;
...
and so on?


As I want it to be like:
./plot_data $a[0] $b[0] >> log_file.log;
./plot_data $a[1] $b[1] >> log_file.log;
./plot_data $a[2] $b[2] >> log_file.log;
...
and so on.

That make sense (using [] to represent the elements in the array, starting at 0).
 
Old 05-01-2011, 03:30 PM   #4
Reuti
Senior Member
 
Registered: Dec 2004
Location: Marburg, Germany
Distribution: openSUSE 13.1
Posts: 1,327

Rep: Reputation: 254Reputation: 254Reputation: 254
Aha, I thought you want to get all possible combinations. When it should be only one round, you can replace the path in the statement:
Code:
for FIRST in /analyses/data1/*_prt.txt; do
  SECOND=$(basename $FIRST)
  ./plot_data $FIRST /analyses/data2/${SECOND%prt.txt}ht.txt >> log_file.log;
done
basename will strip off the path, then the suffix will be replaces. If the names are too different, but in the same order you can also fill two arrays:
Code:
FIRST=(/analyses/data1/*_prt.txt)
SECOND=(/analyses/data2/*_ht.txt)
for ((i=0;i<${#FIRST[*]};i++)); do
  ./plot_data $FIRST[i] $SECOND[i] >> log_file.log
done
 
1 members found this post helpful.
Old 05-01-2011, 03:33 PM   #5
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Quote:
Originally Posted by Reuti View Post
Aha, I thought you want to get all possible combinations. When it should be only one round, you can replace the path in the statement:
Code:
for FIRST in /analyses/data1/*_prt.txt; do
  SECOND=$(basename $FIRST)
  ./plot_data $FIRST /analyses/data2/${SECOND%prt.txt}ht.txt >> log_file.log;
done
basename will strip off the path, then the suffix will be replaces. If the names are too different, but in the same order you can also fill two arrays:
Code:
FIRST=(/analyses/data1/*_prt.txt)
SECOND=(/analyses/data2/*_ht.txt)
for ((i=0;i<${#FIRST[*]};i++)); do
  ./plot_data $FIRST[i] $SECOND[i] >> log_file.log
done
No worries... The files do have different notation, so the second way may be the way to go.. I am going to try that.

I guess though, what does: #FIRST[*] mean? I am guessing the number of elements in the array? total?
 
Old 05-01-2011, 03:38 PM   #6
Reuti
Senior Member
 
Registered: Dec 2004
Location: Marburg, Germany
Distribution: openSUSE 13.1
Posts: 1,327

Rep: Reputation: 254Reputation: 254Reputation: 254
Quote:
Originally Posted by towed View Post
I guess though, what does: #FIRST[*] mean? I am guessing the number of elements in the array? total?
Yep. And it starts at 0.

When they have different names: do they have the same order? I mean: you might end up with different and wrong combinations otherwise.
 
1 members found this post helpful.
Old 05-01-2011, 03:40 PM   #7
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Quote:
Originally Posted by Reuti View Post
Yep. And it starts at 0.

When they have different names: do they have the same order? I mean: you might end up with different and wrong combinations otherwise.
Yeah, they are in the same order and have the same number of the files... That is why I used the ls -1 to ensure that they would be paired togather... can I use that still in:

blend=(/data3/etownsend/analyses/blend/cases_reran/ppaes_join_200*_prt.txt)

like:
blend=(ls -1 /data3/etownsend/analyses/blend/cases_reran/ppaes_join_200*_prt.txt)

?
 
Old 05-01-2011, 03:48 PM   #8
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Quote:
Originally Posted by Reuti View Post
If the names are too different, but in the same order you can also fill two arrays:
Code:
FIRST=(/analyses/data1/*_prt.txt)
SECOND=(/analyses/data2/*_ht.txt)
for ((i=0;i<${#FIRST[*]};i++)); do
  ./plot_data $FIRST[i] $SECOND[i] >> log_file.log
done
It seems in the second way that: $SECOND[i] is getting parsed with the [i], which throws off the program... Any idea why? could it be because only FIRST is referenced when the for loop is started?

Actully, both [i] are getting passed in...

Last edited by towed; 05-01-2011 at 03:52 PM.
 
Old 05-01-2011, 03:51 PM   #9
Reuti
Senior Member
 
Registered: Dec 2004
Location: Marburg, Germany
Distribution: openSUSE 13.1
Posts: 1,327

Rep: Reputation: 254Reputation: 254Reputation: 254
You won't need it I think. `ls -1 ...` will list in one column on screen. But inside any assignment, it’s always used in this way by default.

NB: I forgot the curly braces in the call’s arguments: $FIRST[i] => ${FIRST[i]}
 
1 members found this post helpful.
Old 05-01-2011, 03:54 PM   #10
David the H.
Bash Guru
 
Registered: Jun 2004
Location: Osaka, Japan
Distribution: Debian sid + kde 3.5 & 4.4
Posts: 6,823

Rep: Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958
Code:
for ((i=0;i<${#FIRST[*]};i++)); do
  ./plot_data ${FIRST[i]} ${SECOND[i]} >> log_file.log
done
There's a more convenient way to do this.
Code:
for i in ${!FIRST[*]}; do
  ./plot_data ${FIRST[i]} ${SECOND[i]} >> log_file.log
done
${!array[*]} and ${!array[@]} expand to a list of the index elements of the array. This makes it a snap to loop through them, and be sure that you only get elements that actually exist.


As for using ls to set an array, you need do this:
Code:
blend=( $(ls -1 /data3/etownsend/analyses/blend/cases_reran/ppaes_join_200*_prt.txt) )
The array is set to one element per "word" that exists inside the parentheses. So you have to use a command substitution to generate that list.

It's still not advisable nor necessary to use ls though. If the files are there, then simple globbing should generate exactly the same list as ls does.

Last edited by David the H.; 05-01-2011 at 03:55 PM. Reason: fixed brackets
 
1 members found this post helpful.
Old 05-01-2011, 03:54 PM   #11
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Quote:
Originally Posted by towed View Post
It seems in the second way that: $SECOND[i] is getting parsed with the [i], which throws off the program... Any idea why? could it be because only FIRST is referenced when the for loop is started?

Actully, both [i] are getting passed in...
I believe they need ${FIRST[i]} to be used this way... Does that sound right? or else [i] gets added to the end...

Thus my script looks like:
[CODE]

FIRST=(/data1/analyses/*_prt.txt)
SECOND=(/data2/analyses/*_ht.txt)

echo ${#FIRST[*]} " elements in the data array" > log.log
echo ${#SECOND[*]} " elements in the data array" >> log.log

for ((i=0;i<${#BLEND[*]};i++)); do
./program ${FIRST[i]} ${SECOND[i]}
echo " " >> blend_images_reran.log
echo "--------------" >> blend_images_reran.log
echo " " >> blend_images_reran.log
done

Last edited by towed; 05-01-2011 at 03:58 PM.
 
Old 05-01-2011, 04:01 PM   #12
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Quote:
Originally Posted by David the H. View Post
Code:
for ((i=0;i<${#FIRST[*]};i++)); do
  ./plot_data ${FIRST[i]} ${SECOND[i]} >> log_file.log
done
There's a more convenient way to do this.
Code:
for i in ${!FIRST[*]}; do
  ./plot_data ${FIRST[i]} ${SECOND[i]} >> log_file.log
done
${!array[*]} and ${!array[@]} expand to a list of the index elements of the array. This makes it a snap to loop through them, and be sure that you only get elements that actually exist.


As for using ls to set an array, you need do this:
Code:
blend=( $(ls -1 /data3/etownsend/analyses/blend/cases_reran/ppaes_join_200*_prt.txt) )
The array is set to one element per "word" that exists inside the parentheses. So you have to use a command substitution to generate that list.

It's still not advisable nor necessary to use ls though. If the files are there, then simple globbing should generate exactly the same list as ls does.
Could you elaborate on "expand to a list of the index elements of the array".
Does that mean the for loops knows the filenames in the array?
 
Old 05-01-2011, 04:13 PM   #13
David the H.
Bash Guru
 
Registered: Jun 2004
Location: Osaka, Japan
Distribution: Debian sid + kde 3.5 & 4.4
Posts: 6,823

Rep: Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958Reputation: 1958
Why not try echoing it out and see for yourself?

But if you insist:
Code:
$ array=( Fry Bender Zapp Leela )

$ echo ${array[*]}
Fry Bender Zapp Leela

$ echo ${!array[*]}
0 1 2 3

$ unset array[2]

$ echo ${array[*]}
Fry Bender Leela

$ echo ${!array[*]}
0 1 3
 
Old 05-01-2011, 04:36 PM   #14
towed
LQ Newbie
 
Registered: May 2011
Posts: 8

Original Poster
Rep: Reputation: 0
Yeah, I should have X_X... Don't know why I didn't.

Thanks though, props for the futurama reference in the example.
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
bash shell script split array robertngo Programming 13 06-20-2011 12:01 AM
Simple BASH script; understanding loops and case Sinensis Linux - Newbie 1 06-17-2010 05:32 AM
Need clarification for file to bash script array. lifeforce4 Programming 3 11-27-2009 11:09 AM
Bash Script Array index value Kedelfor Programming 10 04-29-2009 05:37 AM
MAJOR problem ... bash script array HELP !!!!! michael_util Slackware 1 02-13-2004 07:51 AM


All times are GMT -5. The time now is 08:13 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration