Bash Help

dorlack · 11-17-2014, 02:06 PM

Hey friends,

I have a little bash script here and I am not sure what I am missing. It fails on line 14.

line 14: syntax error near unexpected token `done'
line 14: `done'

Here is my short script I would like to run:

Code:

USR="root"
mkdir="mkdir /mnt/folder
mount=”nfsserver1:/exports/mountme”
mountpoint=”/data/mountpoint”

for host in rsc6cn{1..154}
do
echo “=====================================”
ssh $USR@$host “hostname -a && mkdir $dir && mount $mount $mountpoint”
echo “=====================================”
done

I look forward to finding out what I did wrong. I am trying to better my scripting skills.

jpollard · 11-17-2014, 02:19 PM

Well, $dir doesn't seem to be defined (possibly you meant the "mkdir=..." line to be "dir=...")

But your error is actually on line 2 - you are missing a closing quote.

dorlack · 11-17-2014, 02:30 PM

The quotes was a typo on my end when pasting. Also I am aware that I do not have the server and mount points defined. Those will be changed every time the scrip is run. To lesson confusion here is the live script.

# NAME TEXT
# Instruction Text
# Instruction Text
USR="root"
mkdir="mkdir /mnt/ERA01"
mount=”itmgt1:/media/ERAI01”
mountpoint=”/mnt/ERAI01”

for host in wtc6cn{1..10}
do
echo “=====================================”
ssh $USR@$host “hostname -a && if [ -d /dir ]; then mount -t nfs $mount $mointpoint; else mkdir /dir && mount -t nfs $mount $mointpoint; fi”
echo “=====================================”
done

dorlack · 11-17-2014, 02:34 PM

So the scripts job is:
check if the directory is created
if not mkdir /mnt/newdir
mount
finish

jpollard · 11-17-2014, 02:40 PM

well, your script doesn't create /mnt/newdir... it always creates /dir, which is not referenced anywhere in the script.

And there is still an error - mount -t nfs $mount $mointpoint; fi”... hm. I'll guess this is supposed to be part of the preceding line.

You would do better to put code blocks around the script.

dorlack · 11-17-2014, 02:51 PM

okay thanks for catching my typos mainly. Urgh

I will add

Code:

USR="root"
dir="dir /mnt/thunder1"
mkdir="mkdir /mnt/thunder1"
mount=”wtadmin1:/exports/thunder1”
mountpoint=”/data/mountpoint”

for host in wtc6cn{1..10}
do
echo “=====================================”
ssh $USR@$host “hostname -a && mkdir $dir && mount $mount $mountpoint”
echo “=====================================”
done

Any hints on how to fix the error? I understand there is one, or maybe several.

dorlack · 11-17-2014, 03:09 PM

GOT IT!

Code:

if [ -d /dir ]; then mount -t nfs $....; else mkdir /dir && mount -t nfs ...; fi

thanks for your help finding my foolish errors, needed second set of eyes its been a long monday

Keith Hedger · 11-17-2014, 06:05 PM

Both 'mount' and 'mountpoint' are actually commands it is really not a good idea to use vatiable names that clash with real commands, if you must use them then at least upper case them, so 'MOUNTPOINT' instead of 'mountpoint' you will find a loy less errors creeping in if you do, it also helps in debugging as its then obvious that you are refering to a variable or a command.

chrism01 · 11-18-2014, 01:24 AM

Quote:

it is really not a good idea to use vatiable names that clash with real commands

This x 1000 - seriously.. see also 'mkdir'

eg the middle part of post 6 becomes

Code:

mkdir dir /mnt/thunder1

Try setting

Code:

#!/bin/bash
set -xv

at the top of your code; 2nd line shows you exactly what the interpreter is seeing/doing

Keith Hedger · 11-18-2014, 05:00 AM

Missed the 'mkdir' just saw it as a command not as a variable which points up what both I and chrism01 have just said.