[SOLVED] Zenity + kill PID

Tryum · 02-17-2011, 07:53 AM

Do you know the GNOME Panel applet that is terminating running applications after clicking on them with the cursor and confirming the action with a Yes/No dialogue?

I know about xkill, but it is not satisfying due to it has not confirmation dialogue.

Instead, I would like to use xprop and kill and zenity

Here's what I have accomplished thus far:

PID_NUMBER

Code:

xprop|grep "PID"|sed "s/[^0-9]//g"

APPLICATION_NAME

Code:

xprop|grep "WM_CLASS"|cut -d \" -f 2

It should do something like this:

Code:

zenity --question --text "Are you sure you want to terminate <APPLICATION_NAME>?"; kill pid <PID_NUMBER>

Any solutions?

David the H. · 02-17-2011, 11:47 AM

Something like this?

Code:

#!/bin/bash

IFS=$'\n'

array=( $( xprop | sed -rn -e '/WM_CLASS/ s/^.*"([^"]*)"$/\1/p' -e '/PID/ s/[^[:digit:]]//gp' ) )

zenity --question --text "Are you sure you want to terminate ${array[1],,}?"

case $? in

     0) kill ${array[0]}
        exit $?
     ;;

     *) echo "Operation canceled."
        exit 3
     ;;

esac

Note that you can use a single sed command to do all the work, instead of multiple pipes.

The sed command above seems to reliably output the window name first, then the PID. I chose the last WM_CLASS field though instead of the one you used because, a) it's easier to filter with sed, and b) it seems to give a more reliable name. My browser window outputs a line of WM_CLASS(STRING) = "Navigator", "Iceweasel", for example.

I then stored the output in an array. Setting IFS to newline ensures that I get one array element per line of output, no matter what the formatting.

Finally we can use a simple exit code test to determine which action to take, since zenity exits with 0 when "yes" is selected, and 1 when "no" is selected. I also set the script to exit with whatever exit code kill exits with, or "3" if you select cancel.

There's only one more thing to mention. the two commas in "${array[1],,}" convert the contents of the variable to lowercase, but this feature is only available in version 4 of bash. Remove them if your shell is an older version and use something like

Code:

array[1]="$(echo ${array[1]} | tr [:upper:] [:lower:] )"

before running the zenity command.

David the H. · 02-17-2011, 11:53 AM

Oh, and just because I can, here's a variation that replaces the complex sed regex with a simple grep and uses parameter substitution to filter out the desired parts of the string.

Code:

#!/bin/bash

IFS=$'\n'

array=( $( xprop | grep -e 'WM_CLASS' -e 'PID' ) )

array[0]=${array[0]//[^[:digit:]]}
array[1]=${array[1]%\"}
array[1]=${array[1]##*\"}

zenity --question --text "Are you sure you want to terminate ${array[1],,}?"

case $? in

     0) kill ${array[0]}
        exit $?
     ;;

     *) echo "Operation canceled"
        exit 3
     ;;

esac

MTK358 · 02-17-2011, 01:56 PM

Code:

window_pid=$(xprop | grep '_NET_WM_PID(CARDINAL) = [0-9]\+$' | sed 's/.* \([0-9]*\)$/\1/')

if [ "$window_pid" '=' '' ]; then exit 1; fi

zenity --question --title='Kill Application' \
	--text='Really kill PID '$window_pid'?' \
	--ok-label=Yes --cancel-label=No

if [ $? '!=' 0 ]; then exit 2; fi

kill $window_pid

exit 0

Tryum · 02-23-2011, 06:59 AM

Thank you, to both of you, so much

MTK358 · 02-23-2011, 07:33 AM

Mark the thread as solved.