You have a lot of non-necessary defaults in there (such as generating a cert where someone might have a signed cert prepared already). You also install a lot of non-required packages, e.g. vim. Though I do use vim myself I wouldn't consider it necessary for the installation. Your scripts also reboot the system. This may not be desired and
usually isn't necessary unless there's a kernel upgrade (or some other package such as glibc for e.g.). Another thing to mention is the version of ruby that comes with RHEL is anchient (1.8.7) and so
compiling ruby would be a more recommended method.
When I set up puppet in RHEL I'll likely use your scripts as a reference but I won't be using them directly. Thanks for putting it together.
SAM