[SOLVED] Why wont this script execute?

kenny53067 · 07-23-2011, 01:38 AM

I have added a file named "journal-file to my home directory, and have typed this script into my terminal on my virtual machine, nothing happens. what do I have to do to get this script to execute?

$ cat journal
# journal: add journal entries to the file
# $HOME/journal-file

file=$HOME/journal-file
date >> $file
echo -n "Enter name of person or group:"
read name
echo "$name" >> $file
echo >> $file
cat >> $file
echo "------------------------------------" >> $file
echo >> $file

Nylex · 07-23-2011, 01:41 AM

You need to have a line at the top saying what is used to interpret the script. Since it's a Bash script, you want

#!/bin/bash

at the top. You'll also need to make the script executable with "chmod +x journal".

paulsm4 · 07-23-2011, 01:42 AM

My guess is it's probably hanging here:

Code:

cat [SOMETHING] >> $file

kenny53067 · 07-23-2011, 01:52 AM

does it matter where I put #!/bin/bash or chmod +x journal ?

Do I have to use the $ and "" for these commands?

Nylex · 07-23-2011, 02:13 AM

Quote:

Originally Posted by kenny53067

does it matter where I put #!/bin/bash or chmod +x journal ?

The former must be the first line of the script and the latter is not put in the script. chmod is used to change permissions on a file.

kenny53067 · 07-23-2011, 02:13 AM

Thank you Nylex, with your help I figured out the rest.

akakingess · 07-23-2011, 02:14 AM

Put #!/bin/bash at the top of the script, as it designates what is used to interpret. Also, run the chmod +x journal command from the terminal while in the "home" directory (wherever the script is saved).

Nylex · 07-23-2011, 02:15 AM

paulsm4 is right of course (and the comment was also made in your other thread), though.

catkin · 07-23-2011, 02:15 AM

Quote:

Originally Posted by kenny53067

does it matter where I put #!/bin/bash or chmod +x journal ?

Do I have to use the $ and "" for these commands?

#!/bin/bash must be the first line of the script.

chmod +x journal is a command to run at the command prompt while in the same directory as the journal script to make it executable.

For convenience you may like to adopt the convention of naming your shell scripts with a .sh extension; it is not necessary but helps identify them.

EDIT: I don't understand the question "Do I have to use the $ and "" for these commands?"

kenny53067 · 07-23-2011, 02:36 AM

you saying the very first line should be #!/bin/bash ?

I'm not sure I understand where the chmod command goes.

What I meant was should there be a $ at the beginning of #!/bin bash, and should there be "" around the chmod command.

catkin · 07-23-2011, 02:39 AM

Quote:

Originally Posted by kenny53067

you saying the very first line should be #!/bin/bash ?
Yes

I'm not sure I understand where the chmod command goes.
It doesn't go in the script (see below).

What I meant was should there be a $ at the beginning of #!/bin bash, and should there be "" around the chmod command.
No and no

Here's how the chmod command looks at a command prompt

Code:

c@CW8:~$ chmod +x journal

kenny53067 · 07-23-2011, 02:51 AM

If it doesn't go in the script where does it go?

Sorry for all the questions but I'm just a little lost and I'm trying to figure this out.

Nylex · 07-23-2011, 02:52 AM

On the command line! Again, you use chmod to change the permissions on the script (i.e. who can read, write and execute it). By that logic, it doesn't make sense to put it inside the script.

catkin · 07-23-2011, 02:55 AM

Quote:

Originally Posted by kenny53067

If it doesn't go in the script where does it go?

Sorry for all the questions but I'm just a little lost and I'm trying to figure this out.

It is used as a command at the command prompt. The command prompt is displayed by the shell (usually bash) in a terminal. Which desktop are you using? Could be Gnome, KDE, Unity ... Details of how to start a terminal depend on the desktop.

kenny53067 · 07-23-2011, 03:06 AM

Quote:

Originally Posted by Nylex

On the command line! Again, you use chmod to change the permissions on the script (i.e. who can read, write and execute it). By that logic, it doesn't make sense to put it inside the script.

$ cat journal
# journal: add journal entries to the file
# $HOME/journal-file

file=$HOME/journal-file
date >> $file
echo -n "Enter name of person or group:"
read name
echo "$name" >> $file
echo >> $file
cat >> $file
echo "----------------------------------------------------" >> $file
echo >> $file

In this script, the only command line is the very first line, all the rest are script? is this correct?