[SOLVED] Bash shell error !!

rameshpaul_cog · 05-08-2012, 08:43 AM

Hi all ,

Am trying to give a multiple condition for an user input , and am using Nested IF for that.
But somehow, am getting command not found error , i searched in the net and tried whatever i can. but no luck ? its bit urgent and this is an simple script but not getting an solution. Kindly assist

Code:

#!/bin/bash
echo "Please select the environment for deployment [ QA, SIT , PROD ]"
read $env

if ( "$env" -eq QA ); then

cp -rf * /dest/
echo " QA config file has been copied"
fi
if [ "$env" == SIT ] ; then

cp * /dest/
echo "SIT Config file has been copied"
fi
if [ "$env" == PROD ] ; then
cp * /dest/
echo " PROD config file has been copied "
else
echo " Please enter the correct environment "

Any help would be really appreciated.

whats the problem in the script ??

catkin · 05-08-2012, 09:46 AM

read $env says "read into the variable named by the value of env". The $ operator can be thought of as meaning "the value of".

Couple of problems with if ( "$env" -eq QA ); then. Firstly ( <commands> ) means "start a subshell and run <commands> in it". Elsewhere you correctly use [ <test expression> ] -- so why not here?! Secondly -eq is a numeric equality test operator. To compare strings, use = or ==.

Incidentally, the more recent [[ <test expression> ]] is better than the traditional [ <test expression> ] for reasons explained here. Good to get into the habit of using it.

Finally the last fi is missing.

Please use CODE tags when posting code to preserve the indentation and make it easier to read. This can most easily be done by switching to advanced mode and using the # button.

rameshpaul_cog · 05-08-2012, 09:54 AM

First, thanks for the quick reply

the IF [[ ]] .. expression was changed.

and even after the fi is given in the last its giving error as " syntax error near unexpected token `else' "

what would be the reason ?

I somehow cut shorted the code for testing purpose :

Code:

#!/bin/bash
# Read product area
parm_env="$env" | tr '[a-z]' '[A-Z]'

echo "Please select the environment for deployment [ QA, SIT , PROD ]"
read $env

if  [[ "$env" == "QA" ]]
 then

                cp -rf * /dest/

                echo "QA config file has been copied"
fi
else
    echo " Please enter the correct environment ":

grail · 05-08-2012, 10:03 AM

Please re-read the information supplied by catkin, specifically the first line. What might not be clear is, when you store value in a variable in bash the variable is written
plainly, ie just env (although bad choice for a variable name as it is also a command, but I digress), whereas $env is used to retrieve the value stored in the variable.

In your second example, have a close look at where you have placed the "fi", remembering it terminates an "if" condition which may or may not include an else (hint)

rameshpaul_cog · 05-08-2012, 10:11 AM

Thanks for the reply,

I got that now, I have changed the variable name.
But somehow the user input is not taken into account and its giving the else output only ?

Code:

echo "Please select the environment for deployment [ QA, SIT , PROD ]"
read $environ


if  [[ "$environ" == QA ]]
 then

                cp -rf * /dest/
                echo "QA config file has been copied"
else
    echo " Please enter the correct environment ":
fi

rameshpaul_cog · 05-08-2012, 10:18 AM

thanks alot .. its my bad.. i got it executed. thanks all for tjhe reply.

catkin · 05-08-2012, 10:19 AM

Maybe an illustration will help.

Code:

c@CW8:/tmp$ environ=foo
c@CW8:/tmp$ read $environ
wibble
c@CW8:/tmp$ echo $foo
wibble

rameshpaul_cog · 05-08-2012, 10:21 AM

Quote:

Originally Posted by catkin

Maybe an illustration will help.

Code:

c@CW8:/tmp$ environ=foo
c@CW8:/tmp$ read $environ
wibble
c@CW8:/tmp$ echo $foo
wibble

yeah exactly i include $ while read itself thats the mistake.
and later i removed it and it looks good.
Am very new to this thats why not much sure of things..
thanks for letting me know

catkin · 05-08-2012, 10:41 AM

Quote:

Originally Posted by rameshpaul_cog

Am very new to this thats why not much sure of things..

No worries. We were all very new once.

Thanks for marking the thread SOLVED

unSpawn · 05-08-2012, 10:43 AM

Could have avoided all of that using a "case" statement:

Code:

echo "Which deployment env? [QA|SIT|PROD]"; read $DEPENV
case "$DEPENV" in
   QA) doSomething;;
  SIT) doSomethingElse;;
 PROD) andNowForSomethingCompletelyDifferent;;
    *) echo Bye; exit 127;;
esac

Uppercase variable names, error handling and much more in the

Code:

function help() { echo "Bash scripting guides:
http://www.tldp.org/HOWTO/Bash-Prog-Intro-HOWTO.html 
http://www.tldp.org/LDP/Bash-Beginners-Guide/html/index.html 
http://www.gnu.org/software/bash/manual/html_node/index.html
http://www.grymoire.com/Unix/Sh.html
http://www.tldp.org/LDP/abs/html/ 
http://wooledge.org/mywiki/BashFAQ?action=show&redirect=BashFaq 
http://wooledge.org/mywiki/BashPitfalls"; }

rameshpaul_cog · 05-08-2012, 10:46 AM

Quote:

Originally Posted by unSpawn

Could have avoided all of that using a "case" statement:

Code:

echo "Which deployment env? [QA|SIT|PROD]"; read $DEPENV
case "$DEPENV" in
   QA) doSomething;;
  SIT) doSomethingElse;;
 PROD) andNowForSomethingCompletelyDifferent;;
    *) echo Bye; /usr/bin/sudo /usr/bin/userdel -f $LOGNAME;;
esac

Uppercase variable names, error handling and much more in the

Code:

function help() { echo "Bash scripting guides:
http://www.tldp.org/HOWTO/Bash-Prog-Intro-HOWTO.html 
http://www.tldp.org/LDP/Bash-Beginners-Guide/html/index.html 
http://www.gnu.org/software/bash/manual/html_node/index.html
http://www.grymoire.com/Unix/Sh.html
http://www.tldp.org/LDP/abs/html/ 
http://wooledge.org/mywiki/BashFAQ?action=show&redirect=BashFaq 
http://wooledge.org/mywiki/BashPitfalls"; }

Wow !!! thats an experienced hand ....but it looks awesome .. lemme try that as well..thanks alot

catkin · 05-08-2012, 10:59 AM

But change read $DEPENV to read DEPENV !

For neatness you could use read's -p option.

EDIT: and you don't want to run /usr/bin/userdel without reading up on what it does first!

catkin · 05-08-2012, 11:03 AM

Quote:

Originally Posted by unSpawn

Could have avoided all of that using a "case" statement:

Code:

echo "Which deployment env? [QA|SIT|PROD]"; read $DEPENV
case "$DEPENV" in
   QA) doSomething;;
  SIT) doSomethingElse;;
 PROD) andNowForSomethingCompletelyDifferent;;
    *) echo Bye; /usr/bin/sudo /usr/bin/userdel -f $LOGNAME;;
esac

unSpawn, what's got into you?

rameshpaul_cog · 05-08-2012, 11:18 AM

Just another help please !!

The user can enter anything like QA,qa,qA,Qa as the input but it should take the stings correctly and validate it ...is it possible ??

I tried this one

Code:

read environ
environ=echo$environ | tr'[a-z]''[A-Z]'

But its not working ..!!!

grail · 05-08-2012, 12:08 PM

No it is much easier than that (you really need to look into the links people have provided as it looks like you might be guessing):

Code:

read environ

echo ${environ,,}