[SOLVED] bash: Another script problem (Didn't take long, did it?)

L_Carver · 03-02-2017, 11:33 PM

Non-working code:

Code:

megic=0
tragic=0
while read file0
do
logic=$((tragic+1))

Shellcheck return:

Code:

logic=$((tragic+1))
^-- SC2034: logic appears unused. Verify it or export it.

In a very similar script:

Code:

while read item
do
wilde1=$((yeats+1))
#Likewise
file0=$item

Shellcheck returns no errors. Why? In script 1, logic is used for the first time and defined by the +1 incrementor, as is wilde1 in the second. Why should it work in one but not in the other? (Full scripts are attached, before anyone complains they don't have the code.)

Carver

michaelk · 03-03-2017, 05:23 AM

Look at the two scripts.

In the checkwriter script yeats is used as a loop counter which counts how many files are checked i.e. yeats=$((yeats+1)) and keats counts how many files have a writer tag. wilde1 is also a loop counter and incremented since yeats changes.

In the first script checksource you do not have a loop counter (yeats) nor a if true counter (keats). tragic is never used nor incremented so logic=$((tragic+1)) is always 1. megic is never incremented and I assume it is supposed to count the number of has-xmpsource.txt files.

pan64 · 03-03-2017, 06:28 AM

logic is set in the first script, but not used anywhere (=logic appears unused), so there is no reason to set it.
wilde1 is set the same way, and it is used later.... (echo "Checking file #$wilde1, $item")

L_Carver · 03-03-2017, 09:27 AM

I didn't see where logic wasn't being incremented.

+1 to michaelk as well.

Carver